emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Eric Schulte" <schulte.eric@gmail.com>
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: emacs-orgmode@gnu.org
Subject: Re: Plotting date on xaxis
Date: Thu, 25 Feb 2010 10:44:33 -0700	[thread overview]
Message-ID: <87tyt5xla6.fsf@gmail.com> (raw)
In-Reply-To: <87wry3kqej.wl%ucecesf@ucl.ac.uk> (Eric S. Fraga's message of "Wed, 24 Feb 2010 08:07:48 +0000")

Eric S Fraga <ucecesf@ucl.ac.uk> writes:

> On Tue, 23 Feb 2010 17:05:45 -0700, "Eric Schulte" <schulte.eric@gmail.com> wrote:
>> 
>> Eric S Fraga <ucecesf@ucl.ac.uk> writes:
>> 
>> [...]
>> >
>> > I have narrowed down what causes the problem although I don't
>> > understand why (I haven't had any time to look at the elisp code).
>> > Basically, the problem with Johan's initial table was the extra empty
>> > row at the end:
>> >
>> 
>> Ah,
>> 
>> Thanks for isolating the issue.
>> 
>> It looks like the empty last row is tricking org-plot.el into thinking
>> that the entire Date column contains text labels, so it tries to use the
>> values of that column to label the data with xticlabels [1].  This is
>> useful for histograms such as the "Citas" graph in [2].
>> 
>> So all in all I'd say this is fine behavior for something like org-plot
>> which tries to guess the user's intentions.
>
> Well, good intentions is one thing, wrong behaviour is another?  If
> the user has specified "ind:1 deps:(2)", even if org-plot identifies
> column 1 as having labels for the tic marks, the generated parameter
> to the plot command should be, at best:
>
>   ... using 1:2:xticlabels(1) ...
>

I just applied a patch which results in the above plotting command, and
yields the following gnuplot error when the table contains an empty line

 "illegal day of month"

which to me seems entirely appropriate.

All of the plots form the org-plot page on worg still work with this
patch (which amounts to org-plot's test suite), so I relatively
confident that it shouldn't break any existing functionality.

One problem with org-plot's attempt to guess the best action in each
situation is that the code will get increasingly ugly as these corner
cases continue to arise, and as that happens it becomes increasingly
difficult to know a-priori if a patch will cause unforeseen problems.

Best -- Eric

>
> which is actually nonsensical as well but not as bad as what is
> currently generated:
>
>   ... using 1:xticlabels(1)
>
> which completely ignores the "deps:(2)" option!
>
> In any case, I'm not suggesting in any way that this is a critical
> bug!  Simply removing the empty line allows org-plot to work
> perfectly.

  reply	other threads:[~2010-02-25 17:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 18:31 Plotting date on xaxis Johan Ekh
2010-02-23  9:52 ` Eric S Fraga
2010-02-23 14:47 ` Eric Schulte
2010-02-23 16:27   ` Johan Ekh
2010-02-23 17:15     ` Dan Davison
2010-02-23 17:33       ` Eric Schulte
2010-02-23 22:52   ` Eric S Fraga
2010-02-24  0:05     ` Eric Schulte
2010-02-24  8:07       ` Eric S Fraga
2010-02-25 17:44         ` Eric Schulte [this message]
2010-02-25 20:11           ` Eric S Fraga
2010-02-26 15:09             ` Johan Ekh
2010-05-15 13:47 ` Ivan Vilata i Balaguer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyt5xla6.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).