Re: [PATCH] Always return refreshed category

From: Julien Danjou <julien@danjou.info>
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [PATCH] Always return refreshed category
Date: Fri, 24 Dec 2010 17:33:50 +0100	[thread overview]
Message-ID: <87tyi3p1u9.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: <87r5d7xjfv.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 24 Dec 2010 10:46:28 -0500")


[-- Attachment #1.1.1: Type: text/plain, Size: 516 bytes --]

On Fri, Dec 24 2010, Matt Lundin wrote:

> With your original patch, I am also frequently seeing "???" as a
> category in the agenda buffer. E.g.,
>
> ???:        In  -1 d.:  TODO Christmas gifts wrapped                    :home:
>
> This occurs with files/entries that do not have an in-buffer category
> statement (e.g, #+CATEGORY: or :CATEGORY:).

Seems like the refresh function set this by default if no category is
found. That looks stupid, I wonder why there's that line.

Here's a patch that should fix it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-Fix-in-category.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]

From 89464e137f66cfeb144938692479bf95e9187a4d Mon Sep 17 00:00:00 2001
From: Julien Danjou <julien@danjou.info>
Date: Fri, 24 Dec 2010 17:32:45 +0100
Subject: [PATCH] Fix ??? in category

* org.el (org-refresh-category-properties): Do not set ??? as default
  category if no default.

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/org.el |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 863a80b..5fb2ba4 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8154,8 +8154,7 @@ call CMD."
 		  ((null org-category)
 		   (if buffer-file-name
 		       (file-name-sans-extension
-			(file-name-nondirectory buffer-file-name))
-		     "???"))
+			(file-name-nondirectory buffer-file-name))))
 		  ((symbolp org-category) (symbol-name org-category))
 		  (t org-category)))
 	beg end cat pos optionp)
-- 
1.7.2.3


[-- Attachment #1.1.3: Type: text/plain, Size: 53 bytes --]


-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
