emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: tags grouping not working
@ 2011-01-25 13:36 Benjamin Andresen
  2011-01-25 18:03 ` Jason Dunsmore
  0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Andresen @ 2011-01-25 13:36 UTC (permalink / raw)
  To: emacs-orgmode

Hey there,

I've just upgraded to the latest org-mode HEAD and noticed that the tag
behavior changed. (It now sorts entries, except now grouping is broken.)

This is how it used to work:
(Assume "#+TAGS: { foo(f) bar(b) } quux(q)" for all of this.)

* Foo :foo:

now using M-x org-set-tags-command and pressing 'b' will result in:

* Foo :bar:

now selecting 'q' in the same prompt will result in:

* Foo :bar:quux:

but instead what will happen is:

* Foo :quux:

The offending commit is: 
    commit c7d1e0f997d2aa1043c9cbbf72d03f05195d692e
    Author: Bastien Guerry <bzg@altern.org>
    Date:   Tue Jan 18 00:50:32 2011 +0100

just reverting that piece of code on the current HEAD makes grouping
work again.

best regards,
benny

P.S. Sorry if that has been reported before, I couldn't find any mention
of tags. Also git bisect is handy.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: tags grouping not working
  2011-01-25 13:36 Bug: tags grouping not working Benjamin Andresen
@ 2011-01-25 18:03 ` Jason Dunsmore
  2011-01-26 10:09   ` Carsten Dominik
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Dunsmore @ 2011-01-25 18:03 UTC (permalink / raw)
  To: Benjamin Andresen; +Cc: emacs-orgmode, bastien.guerry

Benjamin Andresen <benny@in-ulm.de> writes:

> Hey there,
>
> I've just upgraded to the latest org-mode HEAD and noticed that the tag
> behavior changed. (It now sorts entries, except now grouping is broken.)
>
> This is how it used to work:
> (Assume "#+TAGS: { foo(f) bar(b) } quux(q)" for all of this.)
>
> * Foo :foo:
>
> now using M-x org-set-tags-command and pressing 'b' will result in:
>
> * Foo :bar:
>
> now selecting 'q' in the same prompt will result in:
>
> * Foo :bar:quux:
>
> but instead what will happen is:
>
> * Foo :quux:
>
> The offending commit is: 
>     commit c7d1e0f997d2aa1043c9cbbf72d03f05195d692e
>     Author: Bastien Guerry <bzg@altern.org>
>     Date:   Tue Jan 18 00:50:32 2011 +0100
>
> just reverting that piece of code on the current HEAD makes grouping
> work again.
>
> best regards,
> benny
>
> P.S. Sorry if that has been reported before, I couldn't find any mention
> of tags. Also git bisect is handy.

Yep, this commit needs to be reverted.  See my message about this:

http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg00942.html

Can you do this Bastien?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: tags grouping not working
  2011-01-25 18:03 ` Jason Dunsmore
@ 2011-01-26 10:09   ` Carsten Dominik
  2011-01-26 11:13     ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Carsten Dominik @ 2011-01-26 10:09 UTC (permalink / raw)
  To: Jason Dunsmore; +Cc: emacs-orgmode, bastien.guerry


On Jan 25, 2011, at 7:03 PM, Jason Dunsmore wrote:

> Benjamin Andresen <benny@in-ulm.de> writes:
>
>> Hey there,
>>
>> I've just upgraded to the latest org-mode HEAD and noticed that the  
>> tag
>> behavior changed. (It now sorts entries, except now grouping is  
>> broken.)
>>
>> This is how it used to work:
>> (Assume "#+TAGS: { foo(f) bar(b) } quux(q)" for all of this.)
>>
>> * Foo :foo:
>>
>> now using M-x org-set-tags-command and pressing 'b' will result in:
>>
>> * Foo :bar:
>>
>> now selecting 'q' in the same prompt will result in:
>>
>> * Foo :bar:quux:
>>
>> but instead what will happen is:
>>
>> * Foo :quux:
>>
>> The offending commit is:
>>    commit c7d1e0f997d2aa1043c9cbbf72d03f05195d692e
>>    Author: Bastien Guerry <bzg@altern.org>
>>    Date:   Tue Jan 18 00:50:32 2011 +0100
>>
>> just reverting that piece of code on the current HEAD makes grouping
>> work again.
>>
>> best regards,
>> benny
>>
>> P.S. Sorry if that has been reported before, I couldn't find any  
>> mention
>> of tags. Also git bisect is handy.
>
> Yep, this commit needs to be reverted.  See my message about this:
>
> http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg00942.html
>
> Can you do this Bastien?

Seems Bastien is too busy right now, so I have reverted this commit.

- Carsten

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: tags grouping not working
  2011-01-26 10:09   ` Carsten Dominik
@ 2011-01-26 11:13     ` Bastien
  0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2011-01-26 11:13 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Jason Dunsmore, emacs-orgmode

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Jan 25, 2011, at 7:03 PM, Jason Dunsmore wrote:
>
>> Yep, this commit needs to be reverted.  See my message about this:
>>
>> http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg00942.html
>>
>> Can you do this Bastien?
>
> Seems Bastien is too busy right now, so I have reverted this commit.

Indeed, thanks Carsten!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-01-26 11:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 13:36 Bug: tags grouping not working Benjamin Andresen
2011-01-25 18:03 ` Jason Dunsmore
2011-01-26 10:09   ` Carsten Dominik
2011-01-26 11:13     ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).