From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bastien.guerry@wikimedia.fr>
Subject: Re: [PATCH] [BUG] Timestamps surrounded by @@ in HTML export
Date: Wed, 02 Feb 2011 11:12:00 +0100
Message-ID: <87tygmd9u7.fsf@gnu.org>
References: <8762t3oje2.fsf@riotblast.dunsmor.com> <87hbcnlmys.fsf@gnu.org>
	<AANLkTikF9KwBvtyniMRFP9wrZPHY=pNk9vXne71ZhB3B@mail.gmail.com>
	<8739o6eph9.fsf@gnu.org>
	<AANLkTimCjmpdfKCcxe=B_1qkbFoANK+rJj2Gk10P8NLc@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=52190 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pkdrc-0002ho-Gw
	for emacs-orgmode@gnu.org; Wed, 02 Feb 2011 09:39:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1PkZhD-0006Ok-Dr
	for emacs-orgmode@gnu.org; Wed, 02 Feb 2011 05:12:20 -0500
Received: from mail-wy0-f169.google.com ([74.125.82.169]:46355)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1PkZhD-0006Mn-8P
	for emacs-orgmode@gnu.org; Wed, 02 Feb 2011 05:12:19 -0500
Received: by wyj26 with SMTP id 26so8199489wyj.0
	for <emacs-orgmode@gnu.org>; Wed, 02 Feb 2011 02:11:57 -0800 (PST)
In-Reply-To: <AANLkTimCjmpdfKCcxe=B_1qkbFoANK+rJj2Gk10P8NLc@mail.gmail.com>
	(Puneeth Chaganti's message of "Wed, 2 Feb 2011 15:25:05 +0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Puneeth Chaganti <punchagan@gmail.com>
Cc: Jason Dunsmore <emacs-orgmode@dunsmor.com>, Org-mode mailing list <emacs-orgmode@gnu.org>

Puneeth Chaganti <punchagan@gmail.com> writes:

>>> I don't really understand what is going on here, but there was one @
>>> still appearing after this patch was applied. I am sending a patch to
>>> remove the one remaining @ symbol in the `org-html-handle-time-stamps`
>>> function. I don't know if this breaks something else and why this was
>>> left out by Jason.
>>
>> Better to test your own patch then ;)  I did so, looks fine, I applied
>> it.  Thanks!
>
> :) I did test my patch and it worked. 

Ah okay, sorry for assuming otherwise!

> But these @ seemed to have been put there for some reason, I wasn't
> able to understand, in the quick look that I had. Anyway, thanks.

It took me a while to understand this as well: when looking at
org-export-as-html, you see some occurrences of "@<tag>".  These
org-specific @tags are escaped and will be taken care of in the 
rest of the function.

But org-html-handle-time-stamps happens after these @tags have 
been taken care of, which means that no @ is necessary in this
function.

Hope this helps :)

-- 
 Bastien