emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Richard Riley <rileyrg@googlemail.com>
Cc: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>
Subject: Re: org mobile - pre hooks
Date: Sun, 06 Mar 2011 01:17:08 +0100	[thread overview]
Message-ID: <87tyfhf6gr.fsf@gnu.org> (raw)
In-Reply-To: <t1ipvzyjo9.fsf@news.eternal-september.org> (Richard Riley's message of "Thu, 03 Mar 2011 22:32:22 +0100")

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi Richard,

Richard Riley <rileyrg@googlemail.com> writes:

> Could I suggest that org-mobile-pre-push-hook is processed at the start
> of the org-mobile-push function before the checks? That way it can be
> used to properly setup mobile e.g using auth-source for the mobile
> password.

This trivial patch will perhaps do.  I'm not using org-mobile.el so
please let me know if there are any side-effects.

Thanks,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-mobile.el.patch --]
[-- Type: text/x-patch, Size: 612 bytes --]

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 5471734..ffdd92c 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -305,9 +305,9 @@ create all custom agenda views, for upload to the mobile phone."
 	  (org-agenda-redo-command org-agenda-redo-command))
       (save-excursion
 	(save-window-excursion
+	  (run-hooks 'org-mobile-pre-push-hook)
 	  (org-mobile-check-setup)
 	  (org-mobile-prepare-file-lists)
-	  (run-hooks 'org-mobile-pre-push-hook)
 	  (message "Creating agendas...")
 	  (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda))
 	  (message "Creating agendas...done")

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

next prev parent reply	other threads:[~2011-03-06  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 21:32 org mobile - pre hooks Richard Riley
2011-03-06  0:16 ` Bastien
2011-03-06  0:17 ` Bastien [this message]
2011-04-15 11:53   ` [Accepted] " Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:5471734 dfblob:ffdd92c
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyfhf6gr.fsf@gnu.org \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=rileyrg@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).