From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [patch][test] Remove jump.el dependency from test execution Date: Mon, 12 Sep 2011 10:37:44 -0600 Message-ID: <87ty8hbtt3.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:47657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R39W3-0000dt-Og for emacs-orgmode@gnu.org; Mon, 12 Sep 2011 12:37:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R39W2-0003re-5m for emacs-orgmode@gnu.org; Mon, 12 Sep 2011 12:37:51 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:39921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R39W1-0003rY-UW for emacs-orgmode@gnu.org; Mon, 12 Sep 2011 12:37:50 -0400 Received: by gya6 with SMTP id 6so351194gya.0 for ; Mon, 12 Sep 2011 09:37:49 -0700 (PDT) In-Reply-To: (Martyn Jago's message of "Mon, 12 Sep 2011 17:04:48 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Applied. Thanks! -- Eric Martyn Jago writes: > Currently it is required to install the git submodule jump.el and > dependencies to run tests, and yet these test helpers are not required > in test execution. > > This patch removes this dependency, whilst loading the test helpers when > they exist (git submodule init && git submodule update). > > The idea is to document the test helper availability to aid development > in the test documentation I am about to generate. > > Best, Martyn > > From b3111a4ea6b2e5b134634c7eebf27a210529df58 Mon Sep 17 00:00:00 2001 > From: Martyn Jago > Date: Mon, 12 Sep 2011 16:50:28 +0100 > Subject: [PATCH] Remove jump.el dependency from test execution > * testing/org-test.el: > Remove jump.el dependency from test execution removing the need for a > user to install git submodules > > --- > testing/org-test.el | 23 ++++++++++++++--------- > 1 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/testing/org-test.el b/testing/org-test.el > index a8b5b49..136a287 100644 > --- a/testing/org-test.el > +++ b/testing/org-test.el > @@ -16,11 +16,13 @@ > ;; called while in a `defun' all ert tests with names matching the > ;; name of the function are run. > > -;;; Prerequisites: > - > -;; ERT and jump.el are both included as git submodules, install with > -;; $ git submodule init > -;; $ git submodule update > +;;; Test Development > +;; For test development purposes a number of navigation and test > +;; function construction routines are available as a git submodule > +;; (jump.el) > +;; Install with... > +;; $ git submodule init > +;; $ git submodule update > > > ;;;; Code: > @@ -38,13 +40,15 @@ > (cons > (expand-file-name "jump" org-test-dir) > load-path)))) > + (require 'cl) > (require 'ert) > (require 'ert-x) > - (require 'jump) > - (require 'which-func) > + (when (file-exists-p > + (expand-file-name "jump/jump.el" org-test-dir)) > + (require 'jump) > + (require 'which-func)) > (require 'org))) > > - > (defconst org-test-default-test-file-name "tests.el" > "For each defun a separate file with tests may be defined. > tests.el is the fallback or default if you like.") > @@ -136,6 +140,7 @@ files." > > > ;;; Navigation Functions > +(when (featurep 'jump) > (defjump org-test-jump > (("lisp/\\1.el" . "testing/lisp/test-\\1.el") > ("lisp/\\1.el" . "testing/lisp/\\1.el/test.*.el") > @@ -178,7 +183,7 @@ files." > " (should-error (error \"errr...\")))\n\n\n" > "(provide '" name ")\n\n" > ";;; " file-name " ends here\n") full-path)) > - (lambda () ((lambda (res) (if (listp res) (car res) res)) (which-function)))) > + (lambda () ((lambda (res) (if (listp res) (car res) res)) (which-function))))) > > (define-key emacs-lisp-mode-map "\M-\C-j" 'org-test-jump) -- Eric Schulte http://cs.unm.edu/~eschulte/