emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Gary Oberbrunner <garyo@oberbrunner.com>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars
Date: Sun, 03 Feb 2013 15:53:07 -0700	[thread overview]
Message-ID: <87txptf1ph.fsf@gmail.com> (raw)
In-Reply-To: CAFChFygWZ9GqgZR8qH133AXwamut6gx0PfaQjxqB2RY5bFNbaw@mail.gmail.com

Gary Oberbrunner <garyo@oberbrunner.com> writes:

> Here's a better version of this patch, which also adds support for
> :colnames, which I needed.  And it adds some doc about what header args are
> used.
>
>  * add a header-row delimiter to the tables returned from mysql
>  * adds new sql-specific header args for the database connection, and
> implements them for mysql
>  * adds support for :colnames (mysql only)
>  * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging
> through it
>

Hi Gary,

Thanks for sharing this patch.  It looks like a solid improvement of
Org's SQL support, and I'd like to apply it, however I need to ask for
two things first.

Most importantly, given the size of the patch you'll have to complete
the Emacs copyright assignment process, see [1].  Less importantly, if
you could re-generate the patch using git format-patch, it will be much
easier to apply.

Thanks!

>
>
>
> On Fri, Feb 1, 2013 at 10:18 AM, Gary Oberbrunner <garyo@oberbrunner.com>wrote:
>
>> Let me know if this would be better as a pull request.  This patch does
>> three things:
>>
>>  * add a header-row delimiter to the tables returned from mysql
>>  * adds new sql-specific header args for the database connection, and
>> implements them for mysql
>>  * (minor) adds an edebug spec to org-babel-result-cond to allow
>> edebugging through it
>>
>> --
>> Gary
>>


Footnotes: 
[1]  http://orgmode.org/worg/org-contribute.html

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

     prev parent reply	other threads:[~2013-02-03 22:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 15:18 patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars Gary Oberbrunner
2013-02-01 18:57 ` Gary Oberbrunner
2013-02-03 22:53   ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txptf1ph.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=garyo@oberbrunner.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).