From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: bug#14374: bug#14374: Possibly incorrect custom :types Date: Thu, 09 May 2013 10:06:43 +0200 Message-ID: <87txmcr2zw.fsf@tanger.home> References: <2mvc6t6i3g.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaLqo-0007fg-R7 for emacs-orgmode@gnu.org; Thu, 09 May 2013 04:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaLqV-00028J-Ku for emacs-orgmode@gnu.org; Thu, 09 May 2013 04:05:18 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:58589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaLqV-00028D-Gu for emacs-orgmode@gnu.org; Thu, 09 May 2013 04:04:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UaLqY-0007p1-6z for emacs-orgmode@gnu.org; Thu, 09 May 2013 04:05:02 -0400 In-Reply-To: <2mvc6t6i3g.fsf@fencepost.gnu.org> Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-Message-ID: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Glenn Morris Cc: 14374@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Glenn Morris writes: Hi Glenn, Thanks for this detailled report. May I ask how you did you tests? I can't find cus-test.el in my Emacs. I've attached a diff patch where I fix some of this. > Package: org-mode > > cus-test.el suggests the following variables may have incorrect > custom :types. (There may be some false positives.) > This refers to Org mode in current Emacs trunk. > > Eg, org-footnote-auto-adjust does not have "nil" as an option. > org-refile-target-verify-function It's a function with no function by default and I don't know how to fix it. Should we use '(choice function nil)? > org-icalendar-combined-description Seems fine to me. > org-link-frame-setup Patched (I've only interferred the functions name could VM users confirmed that they are correct). > org-export-with-archived-trees Patched. > org-bibtex-prefix It's suppose to be a string and after a quick look at the code I think it's safe to set it to nil but I'm not sure. > org-log-note-headings Patched. > org-structure-template-alist Patched. > org-export-html-postamble-format I think it's named `org-html-postamble-format' in master. The docstring and the type talks about an alist but the default value is not. I don't know which one is correct (the default value or the description). > org-get-priority-function Same problem than `org-refile-target-verify-function'. > org-export-odt-content-template-file Now `org-odt-content-template-file', the type is a file but the default value is nil. Should we use '(choice file nil)? > org-export-latex-quotes I couldn't find this variable in master. > org-export-html-toplevel-hlevel Now `org-html-toplevel-hlevel' and it doesn't seem to be wrong. > org-agenda-ndays The type is an integer but the default value is nil. Should we use '(choice integer nil)? I've just seen Carsten's mail so I'll stop here. > org-export-initial-scope > org-plantuml-jar-path > org-export-blocks-witheld > org-make-link-description-function > org-export-html-postamble > org-babel-lob-files > org-agenda-export-html-style > org-clock-heading-function > org-show-notification-handler > org-agenda-custom-commands > org-beamer-outline-frame-options > org-agenda-day-face-function > org-use-fast-tag-selection > org-export-docbook-xsl-fo-proc-command > org-link-translation-function > org-export-docbook-xslt-stylesheet > org-export-docbook-xslt-proc-command > org-columns-modify-value-for-display-function > org-export-html-preamble-format > org-agenda-auto-exclude-function > org-export-docbook-doctype > org-wl-namazu-default-index > org-agenda-inactive-leader > org-export-ascii-underline > org-sparse-tree-default-date-type > org-footnote-auto-adjust > org-protocol-default-template-key --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=defcustom-fixes.path Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXggODdjOWEwNy4uYzcw N2U0NSAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcuZWwKQEAgLTE3NjYs NiArMTc2NiwxMSBAQCBhbm90aGVyIHdpbmRvdy4iCiAJCSAoY29uc3Qgdm0tdmlzaXQtZm9sZGVy KQogCQkgKGNvbnN0IHZtLXZpc2l0LWZvbGRlci1vdGhlci13aW5kb3cpCiAJCSAoY29uc3Qgdm0t dmlzaXQtZm9sZGVyLW90aGVyLWZyYW1lKSkpCisJICAoY29ucyAoY29uc3Qgdm0taW1hcCkKKwkJ KGNob2ljZQorCQkgKGNvbnN0IHZtLXZpc2l0LWltYXAtZm9sZGVyKQorCQkgKGNvbnN0IHZtLXZp c2l0LWltYXAtZm9sZGVyLW90aGVyLXdpbmRvdykKKwkJIChjb25zdCB2bS12aXNpdC1pbWFwLWZv bGRlci1vdGhlci1mcmFtZSkpKQogCSAgKGNvbnMgKGNvbnN0IGdudXMpCiAJCShjaG9pY2UKIAkJ IChjb25zdCBnbnVzKQpAQCAtMjYzOSwxMiArMjY0NCwxMiBAQCBhZ2VuZGEgbG9nIG1vZGUgZGVw ZW5kcyBvbiB0aGUgZm9ybWF0IG9mIHRoZXNlIGVudHJpZXMuIgogCQkJICAgICJIZWFkaW5nIHdo ZW4gY2hhbmdpbmcgdG9kbyBzdGF0ZSAodG9kbyBzZXF1ZW5jZSBvbmx5KSIKIAkJCSAgICBzdGF0 ZSkgc3RyaW5nKQogCSAgICAgICAoY29ucyAoY29uc3QgOnRhZyAiSGVhZGluZyB3aGVuIGp1c3Qg dGFraW5nIGEgbm90ZSIgbm90ZSkgc3RyaW5nKQotCSAgICAgICAoY29ucyAoY29uc3QgOnRhZyAi SGVhZGluZyB3aGVuIGNsb2NraW5nIG91dCIgY2xvY2stb3V0KSBzdHJpbmcpCi0JICAgICAgIChj b25zIChjb25zdCA6dGFnICJIZWFkaW5nIHdoZW4gYW4gaXRlbSBpcyBubyBsb25nZXIgc2NoZWR1 bGVkIiBkZWxzY2hlZHVsZSkgc3RyaW5nKQogCSAgICAgICAoY29ucyAoY29uc3QgOnRhZyAiSGVh ZGluZyB3aGVuIHJlc2NoZWR1bGluZyIgcmVzY2hlZHVsZSkgc3RyaW5nKQorCSAgICAgICAoY29u cyAoY29uc3QgOnRhZyAiSGVhZGluZyB3aGVuIGFuIGl0ZW0gaXMgbm8gbG9uZ2VyIHNjaGVkdWxl ZCIgZGVsc2NoZWR1bGUpIHN0cmluZykKIAkgICAgICAgKGNvbnMgKGNvbnN0IDp0YWcgIkhlYWRp bmcgd2hlbiBjaGFuZ2luZyBkZWFkbGluZSIgIHJlZGVhZGxpbmUpIHN0cmluZykKIAkgICAgICAg KGNvbnMgKGNvbnN0IDp0YWcgIkhlYWRpbmcgd2hlbiBkZWxldGluZyBhIGRlYWRsaW5lIiBkZWxk ZWFkbGluZSkgc3RyaW5nKQotCSAgICAgICAoY29ucyAoY29uc3QgOnRhZyAiSGVhZGluZyB3aGVu IHJlZmlsaW5nIiByZWZpbGUpIHN0cmluZykpKQorCSAgICAgICAoY29ucyAoY29uc3QgOnRhZyAi SGVhZGluZyB3aGVuIHJlZmlsaW5nIiByZWZpbGUpIHN0cmluZykKKyAgCSAgICAgICAoY29ucyAo Y29uc3QgOnRhZyAiSGVhZGluZyB3aGVuIGNsb2NraW5nIG91dCIgY2xvY2stb3V0KSBzdHJpbmcp KSkKIAogKHVubGVzcyAoYXNzcSAnbm90ZSBvcmctbG9nLW5vdGUtaGVhZGluZ3MpCiAgIChwdXNo ICcobm90ZSAuICIldCIpIG9yZy1sb2ctbm90ZS1oZWFkaW5ncykpCkBAIC0xMTk2NSw5ICsxMTk3 MCwxMCBAQCB0aGUgZGVmYXVsdCB3aGVuIHRoZSAvb3JnLW10YWdzLmVsLyBtb2R1bGUgaGFzIGJl ZW4gbG9hZGVkLiAgU2VlIGFsc28gdGhlCiB2YXJpYWJsZSBgb3JnLW10YWdzLXByZWZlci1tdXNl LXRlbXBsYXRlcycuIgogICA6Z3JvdXAgJ29yZy1jb21wbGV0aW9uCiAgIDp0eXBlICcocmVwZWF0 Ci0JICAoc3RyaW5nIDp0YWcgIktleSIpCi0JICAoc3RyaW5nIDp0YWcgIlRlbXBsYXRlIikKLQkg IChzdHJpbmcgOnRhZyAiTXVzZSBUZW1wbGF0ZSIpKSkKKwkgIChzZXQKKwkgICAoc3RyaW5nIDp0 YWcgIktleSIpCisJICAgKHN0cmluZyA6dGFnICJUZW1wbGF0ZSIpCisJICAgKHN0cmluZyA6dGFn ICJNdXNlIFRlbXBsYXRlIikpKSkKIAogKGRlZnVuIG9yZy10cnktc3RydWN0dXJlLWNvbXBsZXRp b24gKCkKICAgIlRyeSB0byBjb21wbGV0ZSBhIHN0cnVjdHVyZSB0ZW1wbGF0ZSBiZWZvcmUgcG9p bnQuCmRpZmYgLS1naXQgYS9saXNwL294LmVsIGIvbGlzcC9veC5lbAppbmRleCA3YTIxODZmLi5k ZjliNjU0IDEwMDY0NAotLS0gYS9saXNwL294LmVsCisrKyBiL2xpc3Avb3guZWwKQEAgLTMyNiwx NCArMzI2LDEzIEBAIHVzZXMgdGhlIHNhbWUgc3VidHJlZSBpZiB0aGUgcHJldmlvdXMgY29tbWFu ZCB3YXMgcmVzdHJpY3RlZCB0byBhIHN1YnRyZWUuIikKIFRoaXMgY2FuIGhhdmUgdGhyZWUgZGlm ZmVyZW50IHZhbHVlczoKIG5pbCAgICAgICAgIERvIG5vdCBleHBvcnQsIHByZXRlbmQgdGhpcyB0 cmVlIGlzIG5vdCBwcmVzZW50LgogdCAgICAgICAgICAgRG8gZXhwb3J0IHRoZSBlbnRpcmUgdHJl ZS4KLWBoZWFkbGluZScgIE9ubHkgZXhwb3J0IHRoZSBoZWFkbGluZSwgYnV0IHNraXAgdGhlIHRy ZWUgYmVsb3cgaXQuCi0KK2hlYWRsaW5lICAgIE9ubHkgZXhwb3J0IHRoZSBoZWFkbGluZSwgYnV0 IHNraXAgdGhlIHRyZWUgYmVsb3cgaXQuCiBUaGlzIG9wdGlvbiBjYW4gYWxzbyBiZSBzZXQgd2l0 aCB0aGUgT1BUSU9OUyBrZXl3b3JkLAogZS5nLiBcImFyY2g6bmlsXCIuIgogICA6Z3JvdXAgJ29y Zy1leHBvcnQtZ2VuZXJhbAogICA6dHlwZSAnKGNob2ljZQogCSAgKGNvbnN0IDp0YWcgIk5vdCBh dCBhbGwiIG5pbCkKLQkgIChjb25zdCA6dGFnICJIZWFkbGluZSBvbmx5IiAnaGVhZGxpbmUpCisJ ICAoY29uc3QgOnRhZyAiSGVhZGxpbmUgb25seSIgaGVhZGxpbmUpCiAJICAoY29uc3QgOnRhZyAi RW50aXJlbHkiIHQpKSkKIAogKGRlZmN1c3RvbSBvcmctZXhwb3J0LXdpdGgtYXV0aG9yIHQK --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Daimrod/Greg --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRi1kZAAoJEBNzVHcrZRiUMy0QAKXsWL+I1WQ/XcNt7SLl9lsc 9osY5M4SEm94sYKGSMRBHwemGjbrWSRs9lR0jRwZhjrR8Lx7J4Bl60L/KbUdVFpm qRdxQxLvUjZW3Gi43KR3AqZFKXNaxItKIFaNGp9Ul3VNbTVRytRrVxces4LnUr0S HbgH70U/zJPiAnve6FiISyIz6cAxI4D+TxZYIiJC6BceC9nnP5QeYGg2rp7Z1rSr 5QIbe1wYQJQVL3/5xcv2blSIGhT+dBKuVnNqP18UuJRTzd5i79LQPnqnlda6ZzYY WHlratYYnl+0utFBrU+YmjqdWXmOh1/b5TVEb2Q04P8of12K1FGW0zFogevZDga1 ToWH5Skckvgt0iPDanBNS6W996IyPaP3Jp1pHZQTnf1wyqoguJ7NXEY7xrdEBpKa BMZMjUBsUEnAsZ4Z9dCSGW7n81sTnbbLUrnA3eIjnilUuKF3OEoFb7WtFAAYRsp0 /zuGVmHWtktv4AGqGIjefa5G7ocDlieZS0hhwl7ctbgzZyp39+oEuke5mP54vD+R 6Xj/GZI3vxrro+6yBs3E+5VnSYGQVdJrPgJoXz99tmO8C6HHLEmrxIBUFttzh40O O5MPeicJGm3jOR3l9tYcdYtIDNMNwcct4DrMW7mTgk0QaMK8Qgemtw3JGai68U1H rGaaXT7ypB5fImsBjVT2 =zaIH -----END PGP SIGNATURE----- --==-=-=--