From: Eric Schulte <schulte.eric@gmail.com>
To: Vladimir Lomov <lomov.vl@gmail.com>
Cc: General discussions about Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [BUG][PATCH] Commit '3142297d69f6063221215757a3ba9c74adcf3e43' breaks some my files
Date: Mon, 29 Jul 2013 07:59:28 -0600 [thread overview]
Message-ID: <87txjdo49c.fsf@gmail.com> (raw)
In-Reply-To: 20130729041726.GA697@smoon
Hi Vladimir,
Thanks for mentioning this bug and sending along your trial and error
patch. It helped me to confirm the location of the bug. I've just
pushed up a fix.
Best,
Vladimir Lomov <lomov.vl@gmail.com> writes:
> Hello,
> as title states, commit '3142297d69f6063221215757a3ba9c74adcf3e43'
> breaks one of my Org document (I have many but faced with a bug only
> with particular one). In that file tables contain data (three columns,
> one header) which are transformed and tangle to files (xml, txt). Before
> the commit '3142297d69f6063221215757a3ba9c74adcf3e43' all works fine,
> begining with it I can't tangle files with error message
> BEGIN_EXAMPLE
> mapc: Wrong type argument: consp, nil
> END_EXAMPLE
>
> By means of trial-and-error I made small patch which fixes the problem
> for me. As I'm know very few in Emacs Lisp I'm not sure if my fix is
> correct, so I just added two lines without "proper" reindenting of whole
> block.
>
> BEGIN_EXAMPLE
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index c2722db..013646b 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -2353,6 +2353,7 @@ parameters when merging lists."
> (setq vars (reverse vars))
> (while vars (setq params (cons (cons :var (cddr (pop vars))) params)))
> ;; clear out col-names and row-names for replaced variables
> + (when (and (consp :colname-names) (consp :rowname-names))
> (mapc
> (lambda (name)
> (mapc
> @@ -2365,6 +2366,7 @@ parameters when merging lists."
> params)))
> (list :colname-names :rowname-names)))
> clearnames)
> + )
> (mapc
> (lambda (hd)
> (let ((key (intern (concat ":" (symbol-name hd))))
> END_EXAMPLE
>
>
> P.S. I was lazy to prepare MWE. The mentioned document is available at
> https://github.com/vp1981/scripts/blob/master/docs/openbox/rc.org
>
> ---
> WBR, Vladimir Lomov
--
Eric Schulte
http://cs.unm.edu/~eschulte
prev parent reply other threads:[~2013-07-29 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 4:17 [BUG][PATCH] Commit '3142297d69f6063221215757a3ba9c74adcf3e43' breaks some my files Vladimir Lomov
2013-07-29 13:59 ` Eric Schulte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txjdo49c.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=lomov.vl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).