From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: babel C, C++, D enhancement Date: Sun, 08 Jun 2014 19:22:30 -0400 Message-ID: <87tx7vq955.fsf@gmail.com> References: <878urc0zmw.fsf@bzg.ath.cx> <874n1ryeq1.fsf@bzg.ath.cx> <87y4xgxu74.fsf@Rainer.invalid> <87r438uycj.fsf@bzg.ath.cx> <538BA215.2050305@free.fr> <877g4uezak.fsf@gmail.com> <5394C55B.7010906@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtmRU-00006v-Fl for emacs-orgmode@gnu.org; Sun, 08 Jun 2014 19:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtmRQ-0000Ai-2O for emacs-orgmode@gnu.org; Sun, 08 Jun 2014 19:24:00 -0400 Received: from mail-qa0-x22b.google.com ([2607:f8b0:400d:c00::22b]:63795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtmRP-0000AT-ND for emacs-orgmode@gnu.org; Sun, 08 Jun 2014 19:23:56 -0400 Received: by mail-qa0-f43.google.com with SMTP id m5so7180567qaj.16 for ; Sun, 08 Jun 2014 16:23:52 -0700 (PDT) In-Reply-To: <5394C55B.7010906@free.fr> (Thierry Banel's message of "Sun, 08 Jun 2014 22:19:39 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Thierry Banel Cc: emacs-orgmode@gnu.org Thierry Banel writes: > Hi Eric, hi All > > Here is a new patch (do not apply the previous). > I added a check in the test suite for the D compiler availability > (and for the C++ compiler as well). > It silently returns true when the compiler is not found. > > To run the test suite I did that: > - start from an up-to-date org-mode/ GIT directory > - create a GIT branch, checkout there > - apply the patch : git am patch-file > - make clean > - make autoloads > - make test-dirty > > Eric, this result you were getting is strange: > FAILED ob-C/inhomogeneous_table > It is as though the NEW test suite was run against the OLD ob-C.el > Maybe there was an old .elc compiled file hanging around ? >=20=20 > Anyway, it works fine for me. > Could someone check and tell me if something goes wrong ? > > Have fun > Thierry > Hi Theirry, This new patch looks great, and the test suite passes locally. I've just applied it. Thanks! Eric also, thanks for taking the time to flesh out the commit message > > > Le 06/06/2014 18:31, Eric Schulte a =C3=A9crit : >> Hi Thierry, >> >> This looks wonderful, however after applying this patch I get the >> following errors when running "make test-dirty". >> >>> 10 unexpected results: >>> FAILED ob-C/inhomogeneous_table >>> FAILED ob-D/inhomogeneous_table >>> FAILED ob-D/integer-var >>> FAILED ob-D/list-list-var >>> FAILED ob-D/list-var >>> FAILED ob-D/simple-program >>> FAILED ob-D/string-var >>> FAILED ob-D/table >>> FAILED ob-D/two-integer-var >>> FAILED ob-D/vector-var >> Could you update the test suite so that the C tests pass, and the D >> tests are not executed when D is not available? >> >> Also, could you flesh out the commit message so that it meets the Emacs >> commit message guidelines (http://orgmode.org/worg/org-contribute.html)? >> >> Many Thanks, >> Eric >> >> > > --=20 Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D (see https://u.fsf.org/yw)