From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] Date: Thu, 24 Jul 2014 16:02:50 +0200 Message-ID: <87tx66lur9.fsf@nicolasgoaziou.fr> References: <87fvht9tdo.fsf@yahoo.fr> <87bnsfrycn.fsf@nicolasgoaziou.fr> <878uni7unf.fsf@geodiff-mac3.ulb.ac.be> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAJb9-0003GG-Vo for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAJb2-0005wa-Np for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:02:19 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:33020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAJb2-0005tg-IX for emacs-orgmode@gnu.org; Thu, 24 Jul 2014 10:02:12 -0400 In-Reply-To: <878uni7unf.fsf@geodiff-mac3.ulb.ac.be> (Nicolas Richard's message of "Thu, 24 Jul 2014 15:28:52 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Richard Cc: emacs-orgmode@gnu.org Nicolas Richard writes: > I think it should try to have at least a sensible error message. The > current "Before first headline" isn't quite clear (my patch doesn't > address this, btw). "Not in an Org mode buffer" could be better indeed. Anyway, this kind of change (including compatibility with outline.el) belongs to the high-level function `org-narrow-to-subtree', not the very specific `org-get-limited-outline-regexp'. > I guess you're talking about > http://thread.gmane.org/gmane.emacs.orgmode/84782 Correct. > If core Org functions only care about org-mode buffers, I guess it is > hard to make a minor mode that reuses some of Org to do its job. Unless > that mode is itself in the core of course. e.g. orgstruct-mode does that > and it needs some "core support". Orgstruct mode has indeed some core support, but that's a mistake IMO. Regards, -- Nicolas Goaziou