From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: =?UTF-8?B?W2J1Zz9dIG9yZy1jb3B5LWZhY2UgZG9lc27igJl0IGFkZCBmYWNl?= =?UTF-8?B?cyB0byBvcmctZmFjZXMgY3VzdG9taXplIGdyb3Vw?= Date: Tue, 26 Aug 2014 21:41:37 -0400 Message-ID: <87tx4yu2su.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMSFB-0004yk-Jt for emacs-orgmode@gnu.org; Tue, 26 Aug 2014 21:41:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMSF2-0003HG-Iv for emacs-orgmode@gnu.org; Tue, 26 Aug 2014 21:41:49 -0400 Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:47202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMSF2-0003GW-DB for emacs-orgmode@gnu.org; Tue, 26 Aug 2014 21:41:40 -0400 Received: by mail-qa0-f41.google.com with SMTP id j7so14925474qaq.28 for ; Tue, 26 Aug 2014 18:41:39 -0700 (PDT) Received: from localhost (c-68-81-204-26.hsd1.pa.comcast.net. [68.81.204.26]) by mx.google.com with ESMTPSA id a64sm7914955qge.22.2014.08.26.18.41.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Aug 2014 18:41:39 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: orgmode list Hello all, I=E2=80=99ve noticed that the faces defined by org-copy-face are not added = to the org-faces customize group. This is in accordance with the docstring of =E2=80=98copy-face=E2=80=99, which says (in part) =E2=80=9CThis function= does not copy face customization data, so NEW-FACE will not be made customizable. Most Lisp code should not call this function; use `defface' with :inherit instead.=E2=80=9D I think it=E2=80=99s at best an odd surprise and at worst a bug that all or= g=E2=80=99s faces are not accessible from the org-faces customize group. Would there be any objection to replacing all uses of this function with :inherit as recommended by the docstring, and removing the org-copy-face function? For reference, here are the uses of the function, as returned by rgrep: ./lisp/org-faces.el:431:(org-copy-face 'org-todo 'org-checkbox-statistics-t= odo ./lisp/org-faces.el:434:(org-copy-face 'org-done 'org-checkbox-statistics-d= one ./lisp/org-faces.el:540:(org-copy-face 'org-meta-line 'org-block-begin-line ./lisp/org-faces.el:543:(org-copy-face 'org-meta-line 'org-block-end-line ./lisp/org-faces.el:560:(org-copy-face 'org-block 'org-quote ./lisp/org-faces.el:562:(org-copy-face 'org-block 'org-verse ./lisp/org-faces.el:600:(org-copy-face 'org-agenda-structure 'org-agenda-da= te ./lisp/org-faces.el:603:(org-copy-face 'org-agenda-date 'org-agenda-date-to= day ./lisp/org-faces.el:607:(org-copy-face 'secondary-selection 'org-agenda-clo= cking ./lisp/org-faces.el:610:(org-copy-face 'org-agenda-date 'org-agenda-date-we= ekend ./lisp/org-faces.el:719:(org-copy-face 'org-time-grid 'org-agenda-current-t= ime ./lisp/org-faces.el:791:(org-copy-face 'mode-line 'org-mode-line-clock ./lisp/org-faces.el:793:(org-copy-face 'mode-line 'org-mode-line-clock-over= run Thanks, --=20 Aaron Ecay