From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Pip Cet <pipcet@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: re-search-forward hang in org-link-search
Date: Fri, 14 Aug 2015 22:41:46 +0200 [thread overview]
Message-ID: <87tws1pppx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAOqdjBe4LO2nWJsJBaghU4KAw8nbU=ujZQLEp4Py3Z3TLn2VVA@mail.gmail.com> (Pip Cet's message of "Fri, 14 Aug 2015 16:55:34 +0000")
Pip Cet <pipcet@gmail.com> writes:
> Of course, here we go. Please let me know if there's anything wrong
> with it still. (I don't think gmail copy-and-paste preserves tabs, so
> this is sent as an attachment. Is that okay, for future reference?)
>
> It would be great if README_contribute could be updated no longer to
> refer to ChangeLog files, and instead refer to the Emacs CONTRIBUTE
> file (it would also be great if the special git commit messages could
> be generated as easily as C-x 4 a does for ChangeLog entries. What do
> people use for that?); I've attached a patch to change that as well,
> but I'm not sure whether it's still properly a TINYCHANGE. Again, it
> would be great if you could let me know if there's anything wrong with
> it so I can avoid making the same mistake for future contributions.
Thanks for your patches. They look good. I applied them with very minor
tweaks, explained below.
> Subject: [PATCH 1/2] org.el: fix recursive regular expression backtracking
"Fix" needs to be capitalized.
>
> * org.el (org-link-search): Avoid recursive regexp
> backtracking behaviour when following search links.
Emacs uses American spelling: "behavior".
> Subject: [PATCH 2/2] Remove references to ChangeLog.
No full stop at the end of the commit summary.
> * README_contribute: remove references to ChangeLog. Instead,
"Remove"
> + - Org-mode no longer uses ChangeLog entries to document
We try to change "Org-mode" into "Org mode" whenever we can.
> + changes. Instead, special commit messages are used, as
Sentences are separated with two spaces.
Regards,
next prev parent reply other threads:[~2015-08-14 20:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 18:00 re-search-forward hang in org-link-search Matthew MacLean
[not found] ` <CAOqdjBcwTCOUePnCkS5tamMROs+SEmruyAquDXykbkO4j3Hwag@mail.gmail.com>
2015-08-13 18:36 ` Matthew MacLean
2015-08-13 18:50 ` Pip Cet
2015-08-13 18:55 ` Matthew MacLean
2015-08-13 23:37 ` Nicolas Goaziou
2015-08-14 16:55 ` Pip Cet
2015-08-14 20:41 ` Nicolas Goaziou [this message]
2015-08-18 17:30 ` Bastien
2015-08-18 17:48 ` Matthew MacLean
2015-08-18 17:54 ` Bastien
2015-08-18 17:58 ` Matthew MacLean
2015-08-18 18:01 ` Bastien
2015-08-18 17:57 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tws1pppx.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).