emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Commit 6d2ab40 breaks table input in R
@ 2015-09-23 17:17 Charles C. Berry
  2015-09-23 21:00 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Charles C. Berry @ 2015-09-23 17:17 UTC (permalink / raw)
  To: Org-Mode mailing list


This ECM fails with an error starting with the above commit.

#+NAME: numeric
| 1 | 2 | 3 |
| 4 | 5 | 6 |


#+BEGIN_SRC R :var df=numeric
df
#+END_SRC

Similar tests in test-ob-R.el also fail.

orgtbl-to-tsv now returns a propertized string.

---

Should this be fixed in org-table.el or downstream in ob-R.el?

Maybe like this:

diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index 4bd6eea..4f9fb91 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -239,7 +239,8 @@ This function is called by 
`org-babel-execute-src-block'."
  	     (min (if lengths (apply 'min lengths) 0)))
          ;; Ensure VALUE has an orgtbl structure (depth of at least 2).
          (unless (listp (car value)) (setq value (list value)))
-	(let ((file (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field)))
+	(let ((file (org-no-properties
+		     (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field))))
  	      (header (if (or (eq (nth 1 value) 'hline) colnames-p)
  			  "TRUE" "FALSE"))
  	      (row-names (if rownames-p "1" "NULL")))




Chuck

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Commit 6d2ab40 breaks table input in R
  2015-09-23 17:17 Commit 6d2ab40 breaks table input in R Charles C. Berry
@ 2015-09-23 21:00 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-09-23 21:00 UTC (permalink / raw)
  To: Charles C. Berry; +Cc: Org-Mode mailing list

Hello,

"Charles C. Berry" <ccberry@ucsd.edu> writes:

> This ECM fails with an error starting with the above commit.
>
> #+NAME: numeric
> | 1 | 2 | 3 |
> | 4 | 5 | 6 |
>
>
> #+BEGIN_SRC R :var df=numeric
> df
> #+END_SRC
>
> Similar tests in test-ob-R.el also fail.
>
> orgtbl-to-tsv now returns a propertized string.

Indeed. This is a bug, which is now fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-23 20:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-23 17:17 Commit 6d2ab40 breaks table input in R Charles C. Berry
2015-09-23 21:00 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).