From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: org-gnus-store-link wrong if used from article buffer when
 point moved in summary [8.2.10 (release_8.2.10 @
 /usr/share/emacs/25.3/lisp/org/)]
Date: Sat, 03 Mar 2018 23:36:06 +0100
Message-ID: <87tvtwg52h.fsf@nicolasgoaziou.fr>
References: <87efl4xabn.fsf@fsfe.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1esFlD-0006no-TF
	for emacs-orgmode@gnu.org; Sat, 03 Mar 2018 17:36:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1esFlC-0001LF-Ub
	for emacs-orgmode@gnu.org; Sat, 03 Mar 2018 17:36:11 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:56705)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1esFlC-0001JI-O6
	for emacs-orgmode@gnu.org; Sat, 03 Mar 2018 17:36:10 -0500
In-Reply-To: <87efl4xabn.fsf@fsfe.org> (Kevin Brubeck Unhammer's message of
	"Thu, 01 Mar 2018 13:13:48 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kevin Brubeck Unhammer <unhammer@fsfe.org>
Cc: emacs-orgmode@gnu.org

Hello,

Kevin Brubeck Unhammer <unhammer@fsfe.org> writes:

> If you open an article in Gnus, then move the point away from the
> summary line of that article in the Summary buffer, then go back to the
> Article buffer and M-x org-store-link, it will link to the article
> you're pointing at in the Summary, not the article in the Article
> buffer.
>
> The issue is at line 145 in
> https://code.orgmode.org/bzg/org-mode/raw/master/lisp/org-gnus.el
> which does
>
> 	    (header (with-current-buffer gnus-summary-buffer
> 		      (gnus-summary-article-header)))
>
> (I'm running 8.2.10 normally, but I've tried the most recent org-gnus.el
> and it's the same, and the code makes it clear why.)
>
> In my own code I use the following workaround:
>
>       (if (eq major-mode 'gnus-article-mode)
>           (save-window-excursion (gnus-article-show-summary)
>                                  (org-store-link nil))
>         (org-store-link nil))
>
> although someone with knowledge of gnus internals might be able to avoid
> the call to (gnus-configure-windows 'article) that changes the window
> configuration. (Or maybe org-mode should simply use the above workaround
> since that assumes less about gnus internals, which might change more
> than its public API.)

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou