emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Allen Li <darkfeline@felesatra.moe>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Bug: protocol capture without url corrupts org-stored-links [9.1.14 (9.1.14-1059-gadec50-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20181211/)]
Date: Wed, 12 Dec 2018 17:38:24 +0100	[thread overview]
Message-ID: <87tvjiittr.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADbSrJzDTwESgwG6Z1H5fNR2UHwf7_3Z7PBPBTGS5Q1HV59bDw@mail.gmail.com> (Allen Li's message of "Tue, 11 Dec 2018 19:38:06 -0800")

Hello,

Allen Li <darkfeline@felesatra.moe> writes:

> I didn't realize that org-protocol-capture is documented for URLs,
> since the concept of capturing through org-protocol is useful for
> non-web browser contexts.
>
> Anyway, I'm not interested in updating the documentation for
> org-protocol-capture at the moment, but even if org-protocol-capture
> is documented to need a URL, it seems wrong for it to corrupt
> org-stored-links but otherwise function correctly if a URL was not
> provided.

Could you give more context about the bug you're encountering? What does
mean "function correctly if a URL was not provided"? What is the use
case? What result did you expect, besides not encountering an error
message?

There are multiple ways to solve this. In particular, if a URL is not
provided, it seems natural to store nil instead, as
`org-protocol-capture' currently does. If we do not support missing URL,
then it should raise an error instead of letting it slip into
`org-insert-link'. If we do, then `org-insert-link' should handle it
gracefully.

So, again, more context could help understanding what is the best
solution.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2018-12-12 18:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  3:18 Bug: protocol capture without url corrupts org-stored-links [9.1.14 (9.1.14-1059-gadec50-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20181211/)] Allen Li
2018-12-12  3:38 ` Allen Li
2018-12-12 16:38   ` Nicolas Goaziou [this message]
2018-12-12 22:59     ` Allen Li
2018-12-18  8:34       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvjiittr.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=darkfeline@felesatra.moe \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).