From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ILywLHJOql5ZIAAA0tVLHw (envelope-from ) for ; Thu, 30 Apr 2020 04:05:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GBh4B3tOql4/JAAAB5/wlQ (envelope-from ) for ; Thu, 30 Apr 2020 04:05:15 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 04EE394017B for ; Thu, 30 Apr 2020 04:05:14 +0000 (UTC) Received: from localhost ([::1]:60266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU0Rl-0005KX-Vx for larch@yhetil.org; Thu, 30 Apr 2020 00:05:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47694) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU0RM-0005K6-TV for emacs-orgmode@gnu.org; Thu, 30 Apr 2020 00:04:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU0RL-0006n9-Fp for emacs-orgmode@gnu.org; Thu, 30 Apr 2020 00:04:48 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:58102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jU0RK-0006mw-FO for emacs-orgmode@gnu.org; Thu, 30 Apr 2020 00:04:47 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 8DF79CCAE2; Thu, 30 Apr 2020 00:04:44 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=dlpIbpBa0f4MD5v9Qy/nRxRuFxM=; b=PdAFbW AbphrBPMXXbuMRFzyeV86zMGTmizBbSQE+0Oe68AtdEaREyAsaEJ4GP05zrGFOAj xKVtIjHDnavA4nYkXxyw9aJDC08KmKPn+Ei8b5KL4tlWO6zAMn299ogBWBKGqzbD WR62YsAqycp9bnEdhzzF9QnEYZB3yy9GCUbQI= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 86A7CCCAE1; Thu, 30 Apr 2020 00:04:44 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=UIV6B3g6TnPIHs93kzDaZW92FwOijaEZEpKPQVF4Y6E=; b=x2Zn8WeCyepHdMEzEGGGAiJ6XZoYYvhiplCsBdDBHUg/eMEZwNvBjswV3NvGhuHSBxs1iPUbktYhC1cpulLVV3bOgQ493sup8jwv+goHirvqrYePwAwTGdz8IfNPu/CYTjM9bw48CZvonGFtFdqZCnvtFkX4WNfdCuaeARZVvLI= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id E453DCCAE0; Thu, 30 Apr 2020 00:04:41 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: akater , emacs-orgmode@gnu.org Subject: Re: [PATCH] org-agenda.el: Complete multiple todo keywords In-Reply-To: <871ro6z28e.fsf@gmail.com> References: <871ro6z28e.fsf@gmail.com> Date: Thu, 30 Apr 2020 04:04:39 +0000 Message-ID: <87tv11liug.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B7F92D0E-8A97-11EA-B9D6-B0405B776F7B-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/30 00:04:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 173.228.157.52 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.21 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=PdAFbW A; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=x2Zn8WeC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.21 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.4938043820747]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[kyleam.com:server fail,2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[pobox.com:+,kyleam.com:+]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com,gnu.org]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; FROM_NEQ_ENVFROM(0.00)[kyle@kyleam.com,emacs-orgmode-bounces@gnu.org]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[pobox.com:s=sasl,kyleam.com:s=mesmtp]; URIBL_BLOCKED(0.00)[pobox.com:dkim,kyleam.com:dkim]; FROM_HAS_DN(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[kyleam.com]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 8aUrdTPnHTkE Thanks for the patch. Looks like a nice improvement to me. akater writes: > * lisp/org-agenda.el (org-todo-list): Use completing-read-multiple > instead of completing-read when selecting todo keywords to filter by > in Agenda. This and the rest of the lines were unwrapped. Could you wrap them ~70 characters? (The Org repo's .dir-locals.el sets fill-column to 70.) > * lisp/org-agenda.el (org-todo-list): Fix a typo in the prompt. Thanks for spotting that typo. I think it'd be more common to append this description to the entry above rather than adding another org-todo-list entry. > There is minor UX cost to Helm users: while candidates list used to > appear immediately to Helm users, now Helm users have to hit TAB to > see the list. Just the opinion of one Helm user, but needing to hit tab for crm-based completion has never bothered me too much. But if it did, Helm allows specifying that certain commands should go through the built-in completion. Out of curiosity I tried with the latest ivy (9e0803c), and I also needed to hit tab before seeing anything. > This inconsistency is not present in vanilla Emacs > completion. I'm confused by this. When I try with no customization (Emacs 26.3), I need to hit tab to see any of the candidates. > The issue had been discussed with experienced Helm developer who > insisted that current Helm behaviour should not change. I think this bit can be pruned from the commit message. > We opted to use custom separator that is more natural in context. Looks like you stuck with "|" as the separator, which seems like a good idea to me. > However, it is unfortunate that string patterns are strings themselves > and are thus indistinguishable from strings; it would be better if crm > exposed separator (the string) on its own in its interface. I'm not quite sure I follow what you're suggesting with the last bit. Could you rephrase the point in a way that is a bit more connected with the code change? This patch sticks with the same separator, so aside from being able to complete multiple things, there's no change in behavior/added restriction here, right?