From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wwEQMKfc0F7QTAAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 09:57:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qEY7K6fc0F5LZwAAbx9fmQ (envelope-from ) for ; Fri, 29 May 2020 09:57:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFED29404D7 for ; Fri, 29 May 2020 09:57:58 +0000 (UTC) Received: from localhost ([::1]:42988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jebm0-0006o3-8p for larch@yhetil.org; Fri, 29 May 2020 05:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeble-0006nw-EG for emacs-orgmode@gnu.org; Fri, 29 May 2020 05:57:34 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:35872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jebld-0001fP-Hr; Fri, 29 May 2020 05:57:34 -0400 Received: by mail-wr1-x434.google.com with SMTP id q11so2856315wrp.3; Fri, 29 May 2020 02:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4C/x2UnjoUfawXa46pntD2FKgdLRGfgQEi+c7wMACLI=; b=LhoIwioah3mqCGR8Ue2iIzBFiU5FnI8KoU23GaLVQ49BuKeXvjnSAQLpjmvm4Iq2U0 VwD1iHndZiKepklnLsm+rGvhEqcYaMVBfX5n+shtJNFTnUD25hjEZF6zO4s96jPr+g29 VoTfz2Ty+QVk/vcHGOeZtxw9Dr+J2pdPLOEPkTxn+gQN5lLGjU24jBSfkgnxpL8ZPZf6 IhbYeOJEIF0/s1OXt64EaQnyuEMfonaItlL+TuAb7GWe8wZPuqVrWuVxoRpu+sDkfUa2 FMxtCdEfFRTDWiPHND/E2plvYSjQ3ifBlpvABlSUEkRoK/A6Rp7hSCin9abUmS0YQncm Qt7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4C/x2UnjoUfawXa46pntD2FKgdLRGfgQEi+c7wMACLI=; b=lzCTsk8bBBUyRkjdEMXi+E8maxWKb6tU62kzbJ8rM8e6mCMqF/oP+/vlkZDGUec8j4 f35dtwty6hSBhTnuKazd4kn2NPJqClGSr80091X0fZS9ZPb5NaXWISp7U/BeBRCf9Ggg cIuvpjSfuMEcQjltWYlj2zH0mpzqueiZtLsrJPe6ekzE/fjJS18HmhApMr72Gxra4nCa Zt22ujhGxCKNaKfGR6GmEWh73MQqnNfnLkSHmdYImovI74D66rsXhQKOuzouh3WWCOlU bodcLPhOnTauHgf0vTyg/8UuHitEtJUbVV/rdd6hHQYTkTLXtV/lu9nJmpTAubB9uGSP tP/w== X-Gm-Message-State: AOAM531b4awoqInX76RUMGPVOyc/MjIj+SzJCc7YgCjxp3bFwM27ihP8 b/iqxpQ9lrObakOb1LAE2H5eIm3/18k= X-Google-Smtp-Source: ABdhPJxJz9MNUQ/1ttQhtTCV8w4HUzfu9WleSSShU2Gr24MuTUoxVuieBY9KVt+p7DnCwI3A2PcBaw== X-Received: by 2002:a5d:6283:: with SMTP id k3mr7651505wru.422.1590746251142; Fri, 29 May 2020 02:57:31 -0700 (PDT) Received: from klegouguec-HP-ProBook-450-G1 (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id k13sm10236354wmj.40.2020.05.29.02.57.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2020 02:57:30 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Brandon Guttersohn Subject: Re: Possible fix for :includes header argument in org-babel C source blocks References: <21b0cd85-d678-2fe6-3c22-e41abc6cf242@guttersohn.org> <87wo51jo5w.fsf@gnu.org> <875zchyq7y.fsf@gmail.com> <87imggx045.fsf@kyleam.com> <875zcgwjo7.fsf@gmail.com> <87blm8v09s.fsf@gmail.com> Date: Fri, 29 May 2020 11:57:29 +0200 In-Reply-To: (Brandon Guttersohn's message of "Thu, 28 May 2020 22:37:32 -0500") Message-ID: <87tuzzukqe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=LhoIwioa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 1.59 X-TUID: 54Beh5161lKL Brandon Guttersohn writes: > Apologies for the regression, and thank you for fixing it. I neglected > to run the tests before suggesting that fix -- I'll try not to do that > again.. No biggie, that got me to finally try out Babel ;) I don't know if it's been mentioned in the "issue tracker?" thread, but if I could pick just *one* feature off web-based forges, it'd be automated testing with CI=E2=80=A6 I find the "make-test-before-commit" discipline easy enough to adhere to at $DAYJOB; it's not as straightforward when contributing to free software, when I'm frequently pressed for time, running on battery on a low-end laptop=E2=80=A6 Running a few unit tests is not a big deal, but it's not trivial to anticipate which ones to run; test-foo.el is rarely enough to catch regressions introduced by tweaking foo.el.=20=20 Having something (e.g. emba.gnu.org) pick up patches sent to the mailing list and report new test failures would be very helpful, for contributors if not for maintainers. > I can at least confirm that the patch wasn't intended to change how > C-header-files are specified in the org-babel-block-header. The goal > was only to change how the headers are formatted in the generated > C-language file during execution, and only for headers which were not > wrapped in <>'s. OK; IIUC, before the patch it was not possible to generate double-quoted includes short of backslash-escaping the double quotes; that's why I assumed that the goal of the patch was to make it easier to use double-quoted includes, which I thought worth advertising in ORG-NEWS.