emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Margin added for overflow visibility problem
@ 2020-12-06  8:57 Fatih Aydin
  2020-12-13  6:56 ` Kyle Meyer
  0 siblings, 1 reply; 5+ messages in thread
From: Fatih Aydin @ 2020-12-06  8:57 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Write a code block in an org file and publish it to a html file. You
will see that only bottom part of the name of the programming language
is visible when you hover on it because of the css of that block
(overflow:auto)
To fix this, a margin-top can be added.
---
 lisp/ox-html.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index d2f24f5c6..1a466fb16 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -300,7 +300,7 @@ property on the headline itself.")
     padding: 3px;
     border: 1px solid black;
   }
-  pre.src:hover:before { display: inline;}
+  pre.src:hover:before { display: inline; margin-top: 14px;}
   /* Languages per Org manual */
   pre.src-asymptote:before { content: 'Asymptote'; }
   pre.src-awk:before { content: 'Awk'; }
-- 
2.29.2

[-- Attachment #2: Type: text/html, Size: 957 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Margin added for overflow visibility problem
  2020-12-06  8:57 [PATCH] Margin added for overflow visibility problem Fatih Aydin
@ 2020-12-13  6:56 ` Kyle Meyer
  2020-12-13 11:38   ` Fatih Aydin
  0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2020-12-13  6:56 UTC (permalink / raw)
  To: Fatih Aydin; +Cc: emacs-orgmode


Fatih Aydin writes:

> Write a code block in an org file and publish it to a html file. You
> will see that only bottom part of the name of the programming language
> is visible when you hover on it because of the css of that block
> (overflow:auto)
> To fix this, a margin-top can be added.

Ah, that's a nice visual improvement.  Thanks!

To more closely follow conventions for commit messages in this project
[1], I'd suggest to rewrite the message to something like this:

--8<---------------cut here---------------start------------->8---
Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem

* lisp/ox-html.el (org-html-style-default): Add the margin-top
property to pre.src:hover:before so that the programming language is
fully visible.

TINYCHANGE
--8<---------------cut here---------------end--------------->8---

Does that look okay to you?  If so, I can amend your commit when
applying.  (I'll wait a few more days for any CSS gurus on the list to
weigh in.)

[1] https://orgmode.org/worg/org-contribute.html#commit-messages


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Margin added for overflow visibility problem
  2020-12-13  6:56 ` Kyle Meyer
@ 2020-12-13 11:38   ` Fatih Aydin
  2020-12-16  5:48     ` Kyle Meyer
  0 siblings, 1 reply; 5+ messages in thread
From: Fatih Aydin @ 2020-12-13 11:38 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Thanks for the suggestion, it's okay for me. I just wanted to make sure
that the issue is clear for everyone by describing the steps.
I also agree with waiting for CSS gurus.

On Sun, Dec 13, 2020 at 6:56 AM Kyle Meyer <kyle@kyleam.com> wrote:

>
> Fatih Aydin writes:
>
> > Write a code block in an org file and publish it to a html file. You
> > will see that only bottom part of the name of the programming language
> > is visible when you hover on it because of the css of that block
> > (overflow:auto)
> > To fix this, a margin-top can be added.
>
> Ah, that's a nice visual improvement.  Thanks!
>
> To more closely follow conventions for commit messages in this project
> [1], I'd suggest to rewrite the message to something like this:
>
> --8<---------------cut here---------------start------------->8---
> Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem
>
> * lisp/ox-html.el (org-html-style-default): Add the margin-top
> property to pre.src:hover:before so that the programming language is
> fully visible.
>
> TINYCHANGE
> --8<---------------cut here---------------end--------------->8---
>
> Does that look okay to you?  If so, I can amend your commit when
> applying.  (I'll wait a few more days for any CSS gurus on the list to
> weigh in.)
>
> [1] https://orgmode.org/worg/org-contribute.html#commit-messages
>

[-- Attachment #2: Type: text/html, Size: 1900 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Margin added for overflow visibility problem
  2020-12-13 11:38   ` Fatih Aydin
@ 2020-12-16  5:48     ` Kyle Meyer
  0 siblings, 0 replies; 5+ messages in thread
From: Kyle Meyer @ 2020-12-16  5:48 UTC (permalink / raw)
  To: Fatih Aydin; +Cc: emacs-orgmode

Fatih Aydin writes:

> Thanks for the suggestion, it's okay for me. I just wanted to make sure
> that the issue is clear for everyone by describing the steps.
> I also agree with waiting for CSS gurus.

Applied (5ee39c352).  Thanks again.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] Margin added for overflow visibility problem
@ 2020-12-06  8:27 Fatih Aydin
  0 siblings, 0 replies; 5+ messages in thread
From: Fatih Aydin @ 2020-12-06  8:27 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Fatih Aydin

---
 lisp/ox-html.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index d2f24f5c6..1a466fb16 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -300,7 +300,7 @@ property on the headline itself.")
     padding: 3px;
     border: 1px solid black;
   }
-  pre.src:hover:before { display: inline;}
+  pre.src:hover:before { display: inline; margin-top: 14px;}
   /* Languages per Org manual */
   pre.src-asymptote:before { content: 'Asymptote'; }
   pre.src-awk:before { content: 'Awk'; }
-- 
2.29.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-16  5:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-06  8:57 [PATCH] Margin added for overflow visibility problem Fatih Aydin
2020-12-13  6:56 ` Kyle Meyer
2020-12-13 11:38   ` Fatih Aydin
2020-12-16  5:48     ` Kyle Meyer
  -- strict thread matches above, loose matches on Subject: below --
2020-12-06  8:27 Fatih Aydin

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).