From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ED63Di6bOWITggEAgWs5BA (envelope-from ) for ; Tue, 22 Mar 2022 10:47:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QH1PDC6bOWLoVQEA9RJhRA (envelope-from ) for ; Tue, 22 Mar 2022 10:47:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F181ACFF9 for ; Tue, 22 Mar 2022 10:47:25 +0100 (CET) Received: from localhost ([::1]:49450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWb6q-0005Wu-EJ for larch@yhetil.org; Tue, 22 Mar 2022 05:47:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWb67-0005Sl-EE for emacs-orgmode@gnu.org; Tue, 22 Mar 2022 05:46:39 -0400 Received: from [2607:f8b0:4864:20::82f] (port=39905 helo=mail-qt1-x82f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWb65-00022u-TO for emacs-orgmode@gnu.org; Tue, 22 Mar 2022 05:46:39 -0400 Received: by mail-qt1-x82f.google.com with SMTP id bp39so2245466qtb.6 for ; Tue, 22 Mar 2022 02:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=w/LKC7Ta2OwqHYnYF+qQm9oOKDQ8KvB+bLU8+1PO/+Q=; b=RtNR6VDxpbw0xzLyr1NQydqGLSxFWsgPamnVyOG3/BNjjB00SwlCUGzmbANIspR51I tIL5aWnyXY1eiAsvQGHWp9iafj9fqYciVsbjf1pnTL2q0PTp8XRuKgvWWtsU7d7t3WVZ 2DsTpy6WHK6ylGY4v1KP/Zxxisrk9nZ5tX+7KwfE3vvnvwXzdDYS90bLfglgSD+XL++N hrJyylS0sjU8V2SaZBEZssgFg/uIoHvYqhtElHX52CIduhFC+bgjfxK/+YsJVTIcLNwW wL0TfSpc3DZJmNetlw82ZW6j9Ff3MW/EAevBHjzlZ4oMYuw2XbxipC1Z24Y67xrlq/G6 E/Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=w/LKC7Ta2OwqHYnYF+qQm9oOKDQ8KvB+bLU8+1PO/+Q=; b=jdcVIjrHqnM/U20wGKrNXUdwMExvt+00vcKwvHH7fk53ZMfIG4u6KTJXJ0dKLXkBfl 3Zb8MaulF0GfvTtgitRXhjSK8jwpJMZcqzrdeSETrx75URzTJt3X6xgQzRtKGx15H7Zl bA+HNrln2noxFieJfwCQuwdnkAASVCANP1oT81TgwOrb7FJl5twjgTu01Uw5NIeEqp37 VlKUZLuZFatxk5OIiMWatKfjCzibJIau+AOqhOD7hYxTT7A2LvJ95BYSIVrvjYYNhPBr CzVMsJkVWF1N0dS3jqR5HwzBc6WdPTbDnNwv9tTpBUi/WuyqGRt+qAfQEQwrn/6hz/om y2wg== X-Gm-Message-State: AOAM532VNp9/fBYkDcFju6SwuriDEQFDV/+I08r7kXsujRQaGKG+9D+S yo5arjgYOpUyC+YDBInjFwY= X-Google-Smtp-Source: ABdhPJyber0JQbY+PhsQnNWZx24owvzoCFu4L3HqduJJ3FkH2ZNX++f1tDuo94mgDU+mqQl6TzRnSQ== X-Received: by 2002:a05:622a:2d5:b0:2e1:ea60:231 with SMTP id a21-20020a05622a02d500b002e1ea600231mr19213424qtx.460.1647942396621; Tue, 22 Mar 2022 02:46:36 -0700 (PDT) Received: from localhost (22.b2.a86c.ip4.static.sl-reverse.com. [108.168.178.34]) by smtp.gmail.com with ESMTPSA id j20-20020a37a014000000b0067b3a0c7d89sm8805262qke.38.2022.03.22.02.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 02:46:36 -0700 (PDT) From: Ihor Radchenko To: Ignacio Casso Subject: Re: [BUG] Agenda no longer works for timestamps inside properties drawer [9.5.2 (release_9.5.2-24-g668205 @ /home/ignacio/repos/emacs/lisp/org/)] In-Reply-To: References: <87v8wje4nd.fsf@localhost> <066001d83d3c$7b463380$71d29a80$@tomdavey.com> Date: Tue, 22 Mar 2022 17:47:03 +0800 Message-ID: <87tubqmi94.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::82f (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=yantar92@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tom@tomdavey.com, emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647942446; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=w/LKC7Ta2OwqHYnYF+qQm9oOKDQ8KvB+bLU8+1PO/+Q=; b=SOz0EPTIqGkPX8wp23IUs4+86YkcfA0A01P/rf1car1xwwyGg7ijDbuQf/beqMUegq3MLx 7bvmUrUL346wq1dULWcX/bHie2IAUzN0AyivNMcdlI1b1tFNiT1DW6pOsz9xFhXZQhtCx2 +OGRmRSlwuGHAdvM2EFuJth5PH3JbzmLVW4+pD1fWAHU6U/R4jWeVzDkDG0R2f/gyUKlr5 erpdyVZsJaFKP69aLPGHuOIuew+u9psUHCQQraDEoDowNf6BaeJCUrXDmTvIJjHLWgngeJ 7GkYDGhWOvsZ9UsCa9g3q7F4i3TZ2FuDSlhXWWbVY7eDHHT4rjoR/7BQedzehw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647942446; a=rsa-sha256; cv=none; b=fYbhkktjs6DR5aRLDzHhZl+kR4g28iYbD4aoF+As+5rjI/rEQUol2f4IUWfGxf15v3or29 RLLhQgAjkBOwQepU+4RQgTD+VE7cazvep6l/lU04A5cnx51WD+xGnU1mVdIJ5hZMMCsbNB mjdm+HwZjaQlrFFQrZXcn9vkJkf08wNr5Y9g6/EXpp1razhXs4fNj7tQrraOFjE1lm8Gtw kpC3kRXElFILHF6AYjjSETEDquxrUVWjWDVqbnMfx+HxKryhlJ2QSK9xilRfhD/5mOgUxH XkNYrW+fuDqwlt9Vt88XVjrpu4byHfpUMkoRTunzWKzE+QdKenHpC+67A7IBIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RtNR6VDx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RtNR6VDx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F181ACFF9 X-Spam-Score: -5.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4uqBieU9zelA Ignacio Casso writes: >>> What you see in the new Org version is not a bug. Property values are >>> treated as plain text by Org. > > I think that even if timestamps were never intended to be used inside > property drawers before, the fact that it worked for a long time and > nothing in the documentation suggested otherwise makes it a de facto > feature, even if unintended, and should be preserved. After further reading the source code, I figured that agenda is, in fact, supposed to handle timestamps inside property drawers. Optional arguments for org-at-timestamp-p imply that, in agenda specifically, timestamps inside node properties are considered timestamps despite they are not being parsed as timestamps by org-element. > I've located the line in org-agenda.el responsible of the new behavior, > and the following patch seems to fix it. I suggest it is incorporated > into the repository, maybe with a variable > org-agenda-skip-timestamps-in-properties-drawer defaulting to t if not > everyone agrees. > - (not (eq 'timestamp (org-element-type (org-element-context))))) > + (not (memq (org-element-type (org-element-context)) '(timestamp node-property)))) I pushed a different version of the patch using org-at-timestamp-p to bugfix as d9bf64f06. Best, Ihor