From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GNmuCrELYGLIPQAAbAwnHQ (envelope-from ) for ; Wed, 20 Apr 2022 15:33:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2AC+CbELYGKSuQAAG6o9tA (envelope-from ) for ; Wed, 20 Apr 2022 15:33:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5D242A6CC for ; Wed, 20 Apr 2022 15:33:36 +0200 (CEST) Received: from localhost ([::1]:54056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nh9yd-000830-95 for larch@yhetil.org; Wed, 20 Apr 2022 09:02:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh9xR-00082S-Uo for emacs-orgmode@gnu.org; Wed, 20 Apr 2022 09:01:22 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:47071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nh9xP-0008BQ-2F for emacs-orgmode@gnu.org; Wed, 20 Apr 2022 09:01:20 -0400 Received: by mail-pg1-x52e.google.com with SMTP id q12so1531758pgj.13 for ; Wed, 20 Apr 2022 06:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=wlQdaywWAYDLFnWr+RV0/873QSqLLKypelfDXPhxKPg=; b=GiG4D/ixDcPoPZREqtMTNUZHxyEt6XlSb26uu37Ykfg9rf8CFp2tGjKDTJcKw3spYo cMGn9p94y1wvMqfUeCnEx/8kS9O2+M7yyy8I5DLXKOrB6hs/dkvAEgwCFYnSZXY56YqQ TSESZOljx2HuCLh7gR/+OWQgq2WkditkN8/cHpstJELULt/6AL6EZK2i5At5mAiOrBSY 53kSeuZVuY7eag1vyUA+fzEZQlUlr8q7bmb8Mq79s8DBsapXK+bSAhR0q3fBhLxZ1WOo 82itbP2sGdq09/4FieKb0D9rYC2Wq9H86AXtm8JBbiz3VtUnU8XEzcy0Tj70opLsmq5E tW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wlQdaywWAYDLFnWr+RV0/873QSqLLKypelfDXPhxKPg=; b=0Xfio6B5Ch9lY/DedmTka/upopqTVRiGyqiIhxZXyhcjsAarGgMnvjcLHDs/Cdh5L1 1gmhJt0Df4RmvWJPY67HYFnJUz9HyVCO7BJMHmg2ffPnnmvdq0byeLqfqJYUoLRQ1/Xj /SSEh46wGXIqWBFGZVe1+j3fC42Giqy/AF+ec+jGvpwNobaadYiOu3d2dVvfpH0pAZ78 FhmwzZLSwcq9Z94SNP9+pl4vMGtqKgkKrqKHmkpP2OSyc9rEkH3PLZkAUlqtekNbLrN2 /2YMHsiQxi1KCZ8oBKkoqo0lsKXyV2nE0mVh09k05UZdEo/dXKH+apDxc+sb8mildxOQ z/4g== X-Gm-Message-State: AOAM530Nfv+lytv/Q/7i9gRJLmxvnLUiisEl+IMi04vH1QvjwGTVmddB iWudfhBwbAyQ+3F64uTiafM= X-Google-Smtp-Source: ABdhPJwCnXI9soGEpm3g1Fe/mP4HCDCQsZQ6F2HZ6iMphg/b6TYTM98ywkPdsYTCaoL/QY9EmkGuVw== X-Received: by 2002:a05:6a00:21c8:b0:4c4:4bd:dc17 with SMTP id t8-20020a056a0021c800b004c404bddc17mr23148981pfj.57.1650459677694; Wed, 20 Apr 2022 06:01:17 -0700 (PDT) Received: from localhost ([64.32.23.62]) by smtp.gmail.com with ESMTPSA id q9-20020a056a00088900b004fe1a045e97sm20515943pfj.118.2022.04.20.06.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:01:16 -0700 (PDT) From: Ihor Radchenko To: John Kitchin Subject: Re: [PATCH] oc-basic: Detect malformed bibtex bibliographies In-Reply-To: References: Date: Wed, 20 Apr 2022 21:02:09 +0800 Message-ID: <87tuankiwe.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email , Bruce D'Arcus Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650461616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wlQdaywWAYDLFnWr+RV0/873QSqLLKypelfDXPhxKPg=; b=TYEFcIYxHuwUmr+SFLS4SG/tUsPlVLPEO5aTsNsJ1aDGi9m5SmPtflywXEqR8YHAqRA0S1 ug7i+OS2ywOC82nFA3Q68X/z2O8ItBCD5xoGhczX+QQ1CNzdwYIUadRfDpux1kIBYfCByw LrpYhUgqiXTOIldgsYiwNAdcy+aAHUFxulgM2ZeFDsiWC1xgIyUasyEC1cuqMPSJ4e+3Nz eDK3i4jI/XleNB0EduFN+8ex/5dfk3joFQDHpoVTezDow/ZDBxpdzHOnnfw9FQ9gWJuIpO k5UVFIg4mT7lmRTX5mRy3A2tJeboKscDkD7Nm4mjYKqZVK412GBYac7MqVkztA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650461616; a=rsa-sha256; cv=none; b=mIsm+i0Gx8C5SQzQLyvHxbd/EJfKA64N5y/pJ1mHEcHt4qL2hQmuHQr0BWz5JWMJCoh/jY Q1QYmp5bs2zhl1QzcIGXlEZryVNs7YSSjeOzX0JJ5lTwWjEHQaQgST7CeMv64OerCwuNs1 OWf8OLcxJtbTJfCNj9U6w8gbcZkWMkS7Iy5dv3i5JjChGN9TKG+KunkoxK33c4SvabaK9Q XULqn/k3Y4jAboq92gQqv9n53RJqlaHSTEn9KSHLqt1nFX8e8Vo145ni+AAIdbmcQ+x2lV 6wk5gNWOTdEE2GTXkYa+Ru/0uf3IVHGc+Njn/HUBTcUSIdfe3Wub8odWjV0vIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="GiG4D/ix"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="GiG4D/ix"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D5D242A6CC X-Spam-Score: 6.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2Glltml2GQAu John Kitchin writes: > I would see if you can cache the result and not do it more than needed; it > can add a performance issue on large files. The results of parsing are already cached. See 7ddc5b57c. With this patch, I'd expect 2x performance degradation on (1) first time Org opens the bibliography in current Emacs session; (2) after bibliography is changed. I believe that it is anyway worth it. Having errors in bibliography can be easily overlooked and can potentially cause annoying issues. Best, Ihor