From: Ihor Radchenko <email@example.com> To: John Kitchin <firstname.lastname@example.org> Cc: org-mode-email <email@example.com>, Bruce D'Arcus <firstname.lastname@example.org> Subject: Re: [PATCH] oc-basic: Detect malformed bibtex bibliographies Date: Wed, 20 Apr 2022 21:02:09 +0800 [thread overview] Message-ID: <87tuankiwe.fsf@localhost> (raw) In-Reply-To: <CAJ51ETp67jayCmpK2nYjD3t5a8OhJP8dKCFu9HW_bvqZB7Dz3A@mail.gmail.com> John Kitchin <email@example.com> writes: > I would see if you can cache the result and not do it more than needed; it > can add a performance issue on large files. The results of parsing are already cached. See 7ddc5b57c. With this patch, I'd expect 2x performance degradation on (1) first time Org opens the bibliography in current Emacs session; (2) after bibliography is changed. I believe that it is anyway worth it. Having errors in bibliography can be easily overlooked and can potentially cause annoying issues. Best, Ihor
prev parent reply other threads:[~2022-04-20 13:33 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-20 12:28 Ihor Radchenko 2022-04-20 12:38 ` Bruce D'Arcus 2022-04-20 12:44 ` John Kitchin 2022-04-20 13:02 ` Ihor Radchenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87tuankiwe.fsf@localhost \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] oc-basic: Detect malformed bibtex bibliographies' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).