From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SMVXBOsDj2K/iwAAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 06:36:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oChMBOsDj2JdugAAauVa8A (envelope-from ) for ; Thu, 26 May 2022 06:36:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C6D61133B for ; Thu, 26 May 2022 06:36:58 +0200 (CEST) Received: from localhost ([::1]:34410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nu5F3-0002Zy-Aa for larch@yhetil.org; Thu, 26 May 2022 00:36:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu5D9-0002Zh-PS for emacs-orgmode@gnu.org; Thu, 26 May 2022 00:34:59 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:41795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu5D8-00022T-8A for emacs-orgmode@gnu.org; Thu, 26 May 2022 00:34:59 -0400 Received: by mail-pf1-x429.google.com with SMTP id p8so739894pfh.8 for ; Wed, 25 May 2022 21:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Nup+M5hpuqj0QIkDtNS+VIHPYlHyqitM6/KXelKOlts=; b=BGwt5WE3M0UnbNIwsMMWNLm6ZlEomNssr6yDr5kyCu+Azn5H0dJA0WvQ7kYwYBvPo4 6eIay8/z9q1xABgRCv6NOAcIpXwD+KuE45l/RjNEq8nboUQEPrneBQnWisKivhBvDgqd 9eLqjqw4PIRAB0VZUVjknCpkasGvXoOsL5EoB4UtmQ1iDwfuVYiN4e5i/wiUQJ/AWJEQ 6//Y3tMidNKctx43tG62y4pukuYXUPKqKMcjfOXbC4CxRQzjFwLov7QJX85qFGAGXn4v CyB+w6+Xiw6uN1EC84TlaGACdCqyIF53af8xkfssDpNsckj2/uecUbFnqAl6nJ2AlB4i bihA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Nup+M5hpuqj0QIkDtNS+VIHPYlHyqitM6/KXelKOlts=; b=Ux7QGdTDdFH2eCbHdnbNDg5jSebhF/U3i+JgtsavJCZXWp9m1mgug9hRncTU9rpzmR 0zy0pf062vEKr/KE8RsSUY7S3KUWHOqaEL9D8eV8XMPiyUx5Zk/hfavS0kx1M741Z77T YDS1253M/dSGtTlnNrq18QGTWjvFsZUTsIRmRE2UETvQ6PTx6cpPKYOC6iDbho7hOPvH 3JjNpZ0Fnxu7nsKciLJLiex9CEYj3+6+CrjY2T20EbI67ndFzL+InKx2VLN0AsSWQPgc hptQYCAPRMMsmyf5qCG/AI9Bu81kYSg3VuPQ3VmUUOqAjpPqktdDBpmx16+tj6jVIrHh pp1Q== X-Gm-Message-State: AOAM531lzGZkInCEAR+M2Lk2N4HqjY0nKNOhOoHsi/uV8zJ5IGrRukrV f/i4zcAWhnP16HYitbBPNns= X-Google-Smtp-Source: ABdhPJwnYTusKsLNkMUp4FMtemyhYmVbILEXC76Lryq9vs/6L7yeIX51zMbCQYVKhH0KzApaWeNAvw== X-Received: by 2002:a05:6a00:1acb:b0:518:99c4:aa2e with SMTP id f11-20020a056a001acb00b0051899c4aa2emr19403658pfv.25.1653539696729; Wed, 25 May 2022 21:34:56 -0700 (PDT) Received: from localhost ([74.222.20.18]) by smtp.gmail.com with ESMTPSA id e4-20020a170902d38400b0015e8d4eb2a9sm271518pld.243.2022.05.25.21.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 21:34:56 -0700 (PDT) From: Ihor Radchenko To: "Aaron L. Zeng" Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer In-Reply-To: <20220522185120.2852682-1-me@bcc32.com> References: <20220522185120.2852682-1-me@bcc32.com> Date: Thu, 26 May 2022 12:35:38 +0800 Message-ID: <87tu9c6hd1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=yantar92@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653539818; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Nup+M5hpuqj0QIkDtNS+VIHPYlHyqitM6/KXelKOlts=; b=BJeGxE91b3OK2U9kYH8fd2m7yFytiNySs2M3b6LKloU1Jvj/Z8LzVAwBRdHudqXp2/y/Ws wp6uATYY0C4IscFSD7WTtDZeOV6/JZt8sP1eRJg0ghnSvnbQZquwqRsnu8LWOe9eaCG6J/ K4XTu+ef9LBNs07FNyxk+pMaOvkF1yFN+d61O7JoQwfbod3Y97pEYaunimtgZVF5p9rI7h hS/eZRSNWEu6TwIucvjjhA46+BESpjUPGQZYgyfs8S3gKN3enwoXYyII/yVNLH4/Rsebms RF16UzisgI77rvVZuI6n+KRezY3fk64ZTXC3GHwra8jfCyPwD6sUkri3U4QYlg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653539818; a=rsa-sha256; cv=none; b=ltEqF2tqyj1rZ6czEifUC7LngjgiKDMMlqM2r82exXG7KVvAH4PUTObRnHy3Ed0X9Rx1Gy pZoyUZRlacJlAWP1x0DfjElSqwYpTJyyFKG0msB5lLizv/OeepbpnG3EoduI8ZTue2jf/Q uykvsxc8QzG1Pa6wryrTOy6y7VdejIgtBw3IvFB4z5tPisZewzAzTWOqMI3aD57SEKdATc rUYXhNh0/7oGWNWoqH6jzB7BZPOb+VkNyNbVcv80L5AXDayERHHuDGEFT4Z4Suy2Y8xjv6 arOi7wwnweeYXrO2HcYcHGKN+1kpeg9Dld4S+p/WqET83KfHKXIKFt1YGWWrgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BGwt5WE3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.04 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BGwt5WE3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9C6D61133B X-Spam-Score: -7.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: wZ1c6Rm5Xpp5 "Aaron L. Zeng" writes: > (I'm resubmitting this patch because my previous submission was in-reply-to > another email which I suspect was ignored. Would love to get this relatively > simple bug fixed. Thanks!) > > * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when > org-todo-yesterday intends to call org-agenda-todo-yesterday with the > same interactive arg. Before this change, the command incorrectly set > the todo state of the task to blank when called with C-u C-u C-u in an > agenda buffer (supposed to bypass any blocked checkboxes/subtasks). Thanks! Applied onto main via 713c15d85. I have made amendments to the commit message. Function/symbol names should be quoted as `org-todo-yesterday'. Best, Ihor