emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Timothy <tecosaur@gmail.com>, Bastien <bzg@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>,
	 Ihor Radchenko <yantar92@gmail.com>,
	Daniel Mendler <mail@daniel-mendler.de>,
Subject: [PATCH] Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)
Date: Sun, 13 Nov 2022 07:38:51 +0000	[thread overview]
Message-ID: <87tu337184.fsf@localhost> (raw)
In-Reply-To: <87sfnn7e8x.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

Timothy <tecosaur@gmail.com> writes:

>>> Sure. Just trying to clarify my confusion. The inconsistency with some
>>> defcustoms using :version and some not is bugging me.
>> Agreed.  It would be better to be consistent with this.
> Given that org-mode is distributed separately to Emacs, and I get the impression
> having a newer org-mode version that Emacs version is not uncommon, I think it
> would make sense to have /just/ org-mode version tags.

I have just updated the :package-version tags in the new and changed
variables in Org 9.6.

I also plan to push the attached change to org-maintenance document in

I think we can replace the old :package keywords as needed, similar to
the Emacs' whitespace policy.

Let me know if there are any objections.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-maintenance.org-Document-updating-package-versio.patch --]
[-- Type: text/x-patch, Size: 1126 bytes --]

From f1e2b8daca3bb4bdde0d6d98376d2f1e4c608e94 Mon Sep 17 00:00:00 2001
Message-Id: <f1e2b8daca3bb4bdde0d6d98376d2f1e4c608e94.1668325064.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Sun, 13 Nov 2022 15:33:50 +0800
Subject: [PATCH] org-maintenance.org: Document updating :package-version

* org-maintenance.org (For minor and major releases): Document that it
is necessary to update :package-version in the new and changed
`defcustom' statements.
 org-maintenance.org | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/org-maintenance.org b/org-maintenance.org
index 3cc1ea53..35b70e0a 100644
--- a/org-maintenance.org
+++ b/org-maintenance.org
@@ -274,6 +274,10 @@ *** For minor and major releases
 When doing a minor or major release, the =main= branch should be merged
 into the =bugfix= branch.
+Also, ~:package-version~ tags should be added to new and changed
+~defcustom~ statements as needed.  If a statement also contain ~:version~
+tag, it should be removed in favor of ~:package-version~.
 *** Releasing by adding a new tag
 :CUSTOM_ID: release-tags

[-- Attachment #3: Type: text/plain, Size: 224 bytes --]

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

  parent reply	other threads:[~2022-11-13  7:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 12:08 [PATCH] Improve look of agenda on graphical displays Stefan Kangas
2022-06-29  9:19 ` Ihor Radchenko
2022-06-29 10:20   ` Stefan Kangas
2022-06-29 12:46     ` [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays) Ihor Radchenko
2022-06-29 12:55       ` Stefan Kangas
2022-06-29 14:07         ` Timothy
2022-06-29 16:56           ` Bruce D'Arcus
2022-11-13  7:38           ` Ihor Radchenko [this message]
2022-11-19 13:03             ` [PATCH] Re: [STYLE] :version tags in defcustom definitions Bastien Guerry
2022-11-20  5:47               ` Ihor Radchenko
2022-06-30  7:28 ` [PATCH] Improve look of agenda on graphical displays Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu337184.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=stefan@marxist.se \
    --cc=tecosaur@gmail.com \
    --cc=yantar92@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).