From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan <org@stefan.failing.systems>, Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-element--cache: (org-agenda) Cached element is incorrect [9.6 (release_9.6-90-gf49ee9 @ /home/stefan/.emacs.d/contrib/org-mode/lisp/)]
Date: Thu, 15 Dec 2022 18:42:18 +0000 [thread overview]
Message-ID: <87tu1wse45.fsf@localhost> (raw)
In-Reply-To: <e6474f07-69dd-49e6-b14f-6daa7c29f548@app.fastmail.com>
Bastien, I need your comment on the old commit of yours.
Stefan <org@stefan.failing.systems> writes:
>> 2. If you can, try to load Emacs with minimal Org-related settings.
>> Then, try to load agenda and let me know if you see the warning.
>
> I did some manual bisecting of my config, and I noticed that the warnings in "Media.org" go away when I remove `(org-startup-align-all-tables t)` from my config.
>
> So I did some more digging, reduced
> my config to just contain `org-startup-align-all-tables` set to t,
> my agendas limited to Media.org,
> and removed most headings from Media.org.
Thanks! It looks like you found the culprit.
`org-startup-align-all-tables' triggers a function that changes buffer
contents (tables) during Org loading. For same reason, this function is
executed with modification hooks being suppressed and cache missing the
edits as a result.
The problematic commit is
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9c4d403ada376dca771d9c2dadd7e9eebf4d5f7f
The commit seems to be applied around the time when we did some
aggressive optimizations for agenda views. However, I do not see any
email thread relevant to this particular commit.
Bastien, do you remember the rationale behind the linked commit? The
commit message is not particularly informative.
It appears to me that removing `org-unmodified' around table alignment
should be safe, but I may be missing something.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-15 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 21:24 [BUG] org-element--cache: (org-agenda) Cached element is incorrect [9.6 (release_9.6-90-gf49ee9 @ /home/stefan/.emacs.d/contrib/org-mode/lisp/)] Stefan
2022-12-15 8:14 ` Ihor Radchenko
2022-12-15 11:58 ` Stefan
2022-12-15 12:16 ` Ihor Radchenko
2022-12-15 18:05 ` Stefan
2022-12-15 18:42 ` Ihor Radchenko [this message]
2023-01-02 7:29 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu1wse45.fsf@localhost \
--to=yantar92@posteo.net \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=org@stefan.failing.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).