From: Ihor Radchenko <yantar92@posteo.net>
To: Ilya Chernyshov <ichernyshovvv@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil
Date: Sat, 08 Jul 2023 08:35:02 +0000 [thread overview]
Message-ID: <87ttueajih.fsf@localhost> (raw)
In-Reply-To: <87edlkyyit.fsf@gmail.com>
Ilya Chernyshov <ichernyshovvv@gmail.com> writes:
>> Interpreting timestamps with :time-range nil and
>> :day-end/:year-end/:month-end non-nil as timerange is a breaking change.
>> Let's avoid it.
>
> Timestamp objects (ranges) with :range-type nil are now interpreted as
> dateranges, as it was before.
I still have questions about this part.
> + (hour-start (org-element-property :hour-start timestamp))
> + (minute-start (org-element-property :minute-start timestamp))
> + (hour-end (or (org-element-property :hour-end timestamp) hour-start))
> + (minute-end (or (org-element-property :minute-end timestamp) minute-start))
> + (day-end (or (org-element-property :day-end timestamp) day-start))
> + (month-end (or (org-element-property :month-end timestamp) month-start))
> + (year-end (or (org-element-property :year-end timestamp) year-start))
I note that *-end is never going to be nil when the corresponding
*-start is non-nil. This will remove some original information about
timestamp that can cause edge cases as I describe below.
> + (time-range-p (and hour-start minute-start minute-end hour-end
So, this (and ...), copied from the old version of the code looks suspicious.
> + (or (/= hour-start hour-end)
> + (/= minute-start minute-end))))
> + (date-range-p (or (and (eq range-type nil) time-range-p)
What about [2023-11-12 12:00-13:00] represented as Elisp AST with :range-type nil?
> + (and day-end month-end year-end
> + (or
> + (/= day-start day-end)
> + (/= month-start month-end)
> + (/= year-start year-end)))))
[2023-11-12 12:00]--[2023-11-12 13:00]?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-08 8:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 12:25 [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil Ilya Chernyshov
2023-02-19 14:11 ` Ilya Chernyshov
2023-02-20 11:07 ` Ihor Radchenko
2023-02-20 16:36 ` Ilya Chernyshov
2023-02-22 11:21 ` Ihor Radchenko
2023-07-01 19:47 ` Ilya Chernyshov
2023-07-02 8:46 ` Ihor Radchenko
2023-07-07 7:24 ` Ilya Chernyshov
2023-07-08 8:35 ` Ihor Radchenko [this message]
2023-07-10 18:19 ` Ilya Chernyshov
2023-07-11 9:02 ` Ihor Radchenko
2023-07-11 13:16 ` Ilya Chernyshov
2023-07-12 8:16 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttueajih.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=ichernyshovvv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).