From: Ihor Radchenko <yantar92@posteo.net>
To: Margaret Patterson <emacs-m@ninecats.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-cite-insert fails to open json format bibliographies that contain entries for books with editors but no authors [9.6.6 (release_9.6.6 @ /snap/emacs/current/usr/share/emacs/29.1/lisp/org/)]
Date: Sat, 26 Aug 2023 16:19:41 +0000 [thread overview]
Message-ID: <87ttslixnm.fsf@localhost> (raw)
In-Reply-To: <c66a6fc7-af6b-5df5-d8ee-b9ed6c7daf6b@ninecats.org>
Margaret Patterson <emacs-m@ninecats.org> writes:
> Thanks! Yes that seems to fix my problem.
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7c929e9d8
> I failed to apply the patch (perhaps because the file is in a different
> place, /lisp/org/ instead of /lisp/ ) however making that change
> manually and rebuilding fixed the problem.
>
> For future reference is there a resource that explains how to apply
> patches for testing? I have emacs installed via the snap package on
> Ubuntu, and in the end (with a lot of help from my spouse) we built it
> directly from source without installing it to test this, but is there a
> more direct way to do this?
We develop Org mode separately from Emacs in a different git repository.
See https://orgmode.org/manual/Installation.html or "source code" link
in https://orgmode.org/
My patch was against Org repository, not Emacs.
Applying a patch is the same as with any other git repo. We might drop a
reference to some online documentation on how to use git, but (1) I am
not sure what should be the place to put such a reference; (2) If you
are unsure how to apply patches, you could ask, and I would offer another
way to test things.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-08-26 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 16:50 [BUG] org-cite-insert fails to open json format bibliographies that contain entries for books with editors but no authors [9.6.6 (release_9.6.6 @ /snap/emacs/current/usr/share/emacs/29.1/lisp/org/)] Margaret Patterson
2023-08-25 8:39 ` Ihor Radchenko
2023-08-26 14:29 ` Margaret Patterson
2023-08-26 16:19 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttslixnm.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-m@ninecats.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).