From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iCtfLnWA+GQYUQEAauVa8A:P1 (envelope-from ) for ; Wed, 06 Sep 2023 15:36:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iCtfLnWA+GQYUQEAauVa8A (envelope-from ) for ; Wed, 06 Sep 2023 15:36:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EF89582C4 for ; Wed, 6 Sep 2023 15:36:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=whxvd.name header.s=MBO0001 header.b=wX1ZJ9sQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694007413; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QWCRWsroHAZv+o/GtvY3T35tINIM3e1gBg0+gACmBgk=; b=uhODTzROTJVkrgp1Z1PGviaQtMSo6hoDqBwANw+Q8q5aeVE7DqeT4KuSuqGHCJoa1Kpgk5 P5A7PjvHbgMC26qSFa+n/ovy02+6EIOGtC6z7U6lGXUWaBLUDTC5Wv/uT0jFpTa6Y+4Cru zY7b5kbbSHVYQjNNqeRyzlUbkgcolMpaSJ/IyMHCCGYsA6IhQ2JGOefJdcCPz/0C+rfzG8 fNZuMyV8obTj7I//L4QMKKkS4R+LVOseC2EtV2QDCMGMM/OX20DtqA1Xwu14YnA4FDLC2h W++U3xipxBVoXeo0aDp2D0hTqv1rGhbgwMhe6oBzis89ADNXiJIOdzzje5nw+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694007413; a=rsa-sha256; cv=none; b=RdKgcCfRljkhhsNnI6iyC4LR5uFPxDy1VzwN87iPsNzLcUDlR6e2JdffL3hz4hXndW/r5Z pDjAT0g7CC/vb+1CG27msu3Sbw8Ke5HLTzx12WR1UmJnFTO95cb01PUPskB5Yy30wIgJoA KEJsNfjKkjsyhZAEMbKlmM/QO7D6/pyydcass8ISyVBRkVlHRzudl+k9RJMu5CtIQASmRg kTD+cV9BA4sLLdNwSMkUJ4GEfQsSBroq5uzeVPrN8MC/3hJyNBhu/Pn5nT2allEzyRzpzI 920LubuS0H8CgDahXmIsN3bAQkYAX7V0fYHd38m7Pn3CVZjVxMIw4DytX3e11w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=whxvd.name header.s=MBO0001 header.b=wX1ZJ9sQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdshe-0006Ai-Pf; Wed, 06 Sep 2023 09:36:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdshc-0006Aa-9P for emacs-orgmode@gnu.org; Wed, 06 Sep 2023 09:36:17 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qdshZ-0001HG-5L; Wed, 06 Sep 2023 09:36:15 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Rgk0k5SYdz9t6j; Wed, 6 Sep 2023 15:36:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1694007366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWCRWsroHAZv+o/GtvY3T35tINIM3e1gBg0+gACmBgk=; b=wX1ZJ9sQMVqnnSIfmQBPp3a8RJyGff7QBby6NXjFmatHs0DtP42KivAgVUlOzbf599G1e4 TI4qo/6oym8rZxRB/Kd6dtDrg0ubtpiatyK5bgpN56086hVVeVqDsrX1ml7VYvlt7VJ6y0 RahIBaRGQJkrnO6cGJ9wm+H8s6jP9QpVTr3Od5yYAZ0H3XdFUeqy1XtADHWwicmhQJfppf xbYFHWlVS0X9UwUZVzcMxy64AZdzjijp2ri4nTOY+iHWO5J0j9qRRDR9jhWftsd/J7aBzs NEmvCWJcdW3hNap7PqecP7N+jbV/NjDO5wvRXEK/Yvif1N363i0LcokppezKsw== References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <875y4oaban.fsf@whxvd.name> <83bkeg4o1u.fsf@gnu.org> <87o7ifu2v8.fsf@localhost> <838r9j339x.fsf@gnu.org> From: Sebastian Miele To: Eli Zaretskii Cc: Ihor Radchenko , 65734@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Wed, 06 Sep 2023 15:30:16 +0200 In-reply-to: <838r9j339x.fsf@gnu.org> Message-ID: <87tts78lve.fsf@whxvd.name> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=iota@whxvd.name; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -9.33 X-Migadu-Queue-Id: 5EF89582C4 X-Migadu-Spam-Score: -9.33 X-TUID: cAL0AVpu5xBq > From: Eli Zaretskii > Date: Wed, 2023-09-06 15:16 +0300 > >> From: Ihor Radchenko >> Date: Wed, 06 Sep 2023 08:23:23 +0000 >> >> Eli Zaretskii writes: >> >> >> The following would do it. I think I tested it rather thoroughly. >> >> During testing I found another bug that is addressed by the let-binding >> >> of kill-read-only-ok during the first kill-region below. >> > >> > Thanks. Sadly, we don't have any tests for this function in our test >> > suite, so verifying this non-trivial change will not be easy... >> >> Then, what should we do to move things forward? I guess the first step >> will be writing these missing tests. > > Yes, that'd be most welcome. I will write the tests. And I will probably come up with an updated version of the original patch. There is at least one cosmetic change. And something else that I want to have tried. May take some time. >> Anything else? > > How about asking on emacs-devel that people who use kill-whole-line > frequently install the patch and run with it for some time? (We could > do that after installing the changes on master, of course.)