From: Ihor Radchenko <yantar92@posteo.net>
To: Uwe Brauer <oub@mat.ucm.es>
Cc: emacs-orgmode@gnu.org
Subject: Re: bizarre: checkbox in properties, counting does not work with subheadings
Date: Mon, 29 Jan 2024 15:13:10 +0000 [thread overview]
Message-ID: <87ttmw41h5.fsf@localhost> (raw)
In-Reply-To: <87k07x8ls8.fsf@mat.ucm.es>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
Uwe Brauer <oub@mat.ucm.es> writes:
> * Everything [3/4]
> ...
> *** DONE Books
> ...
> ** DONE Car
> ...
> ** DONE Food
> ...
> *** WAIT Computer
> ...
> ... The expected behavior should be
>
> #+BEGIN: columnview :maxlevel 2 :skip-empty-rows t :hlines 1 :indent nil :format "%5TODO(Status) %5Nr(Nr) %5Comp1(Comp1){X/} %5Comp2(Comp2){X/}"
> | Status | Nr | Comp1 | Comp2 |
> |--------+----+-------+-------|
> | | | [1/2] | [2/2] |
> | DONE | 2 | [X] | [X] |
> | DONE | 3 | [ ] | [X] |
> #+END:
I am not sure if it is expected.
Why doesn't "DONE Books" contribute to the summary? It is also under
"Everything" headline and has a checkbox.
With the attached patch, the result would be the following:
#+BEGIN: columnview :maxlevel 2 :skip-empty-rows t :hlines 1 :indent nil :format "%5TODO(Status) %5Nr(Nr)%5Comp1(Comp1){X/} %5Comp2(Comp2){X/}"
| Status | Nr | Comp1 | Comp2 |
|--------+----+-------+-------|
| | | [3/3] | [2/3] |
| DONE | 2 | [X] | [X] |
| DONE | 3 | [1/1] | [0/1] |
#+END:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org-colview.el-Fix-computing-summary-with-low-l.patch --]
[-- Type: text/x-patch, Size: 1504 bytes --]
From a4927f9ea530db180efdaea6bb01511c03bb1051 Mon Sep 17 00:00:00 2001
Message-ID: <a4927f9ea530db180efdaea6bb01511c03bb1051.1706541069.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Mon, 29 Jan 2024 16:09:29 +0100
Subject: [PATCH] lisp/org-colview.el: Fix computing summary with low-level
first child
* lisp/org-colview.el (org-columns--compute-spec): Do not assume that
all the children of an entry have the same LAST-LEVEL. Handle
situation when the first child has lower level:
* Heading
****** Child 1
** Child 2
** Child 3
Reported-by: Uwe Brauer <oub@mat.ucm.es>
Link: https://orgmode.org/list/87wn8yj2i5.fsf@localhost
---
lisp/org-colview.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index b1b79257b..39ca01502 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1244,9 +1244,9 @@ (defun org-columns--compute-spec (spec &optional update)
;; property `org-summaries', in alist whose key is SPEC.
(let* ((summary
(and summarize
- (let ((values (append (and (/= last-level inminlevel)
- (aref lvals last-level))
- (aref lvals inminlevel))))
+ (let ((values
+ (cl-loop for l from (1+ level) to lmax
+ append (aref lvals l))))
(and values (funcall summarize values printf))))))
;; Leaf values are not summaries: do not mark them.
(when summary
--
2.43.0
[-- Attachment #3: Type: text/plain, Size: 224 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-01-29 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 12:27 bizarre: checkbox in properties, counting does not work with subheadings Uwe Brauer
2022-10-17 8:08 ` Ihor Radchenko
2024-01-29 15:13 ` Ihor Radchenko [this message]
2024-02-29 10:03 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttmw41h5.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=oub@mat.ucm.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).