From: Suhail Singh <suhailsingh247@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Suhail Singh <suhailsingh247@gmail.com>,
Matt <matt@excalamus.com>,
Org mailing list <emacs-orgmode@gnu.org>
Subject: Re: ob-shell: possibly missing initiate-session functions?
Date: Mon, 17 Jun 2024 14:29:22 -0400 [thread overview]
Message-ID: <87tthrv2wt.fsf@gmail.com> (raw)
In-Reply-To: <878qz3bmjo.fsf@localhost> (Ihor Radchenko's message of "Mon, 17 Jun 2024 15:45:31 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b366a731
#+begin_src diff
(put fname 'definition-name 'org-babel-shell-initialize))
+ (let ((fname (intern (concat "org-babel-prep-session:" name))))
+ (defalias fname
+ (lambda (session params)
+ (:documentation
+ (format "Prepare %s SESSION according to the header arguments specified in PARAMS." name))
+ (let ((explicit-shell-file-name name)
+ (shell-file-name name))
+ (org-babel-prep-session:shell session params))))
+ (put fname 'definition-name 'org-babel-shell-initialize))
+ (let ((fname (intern (format "org-babel-%s-initiate-session" name))))
+ (defalias fname
+ (lambda (session _params)
+ (:documentation
+ (format "Initiate %s session named SESSION." name))
+ (let ((explicit-shell-file-name name)
+ (shell-file-name name))
+ (org-babel-sh-initiate-session session))))
+ (put fname 'definition-name 'org-babel-shell-initialize))
#+end_src
Am I mistaken, or does something still need to be done about
org-babel-shell-initiate-session ?
--
Suhail
next prev parent reply other threads:[~2024-06-17 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 2:48 ob-shell: possibly missing initiate-session functions? Suhail Singh
2024-06-16 18:53 ` Matt
2024-06-16 22:54 ` Suhail Singh
2024-06-17 15:45 ` Ihor Radchenko
2024-06-17 18:29 ` Suhail Singh [this message]
2024-06-18 12:46 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tthrv2wt.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=matt@excalamus.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).