From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: [PATCH] /contrib/lisp/org-collector.el Date: Tue, 10 Aug 2010 09:24:59 -0600 Message-ID: <87sk2m32yc.fsf@gmail.com> References: <733883921.20100810141351@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=33260 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiqhO-00044d-MN for emacs-orgmode@gnu.org; Tue, 10 Aug 2010 11:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiqhN-0003BN-K5 for emacs-orgmode@gnu.org; Tue, 10 Aug 2010 11:25:06 -0400 Received: from mail-pv0-f169.google.com ([74.125.83.169]:45645) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiqhN-0003B7-B2 for emacs-orgmode@gnu.org; Tue, 10 Aug 2010 11:25:05 -0400 Received: by pvc30 with SMTP id 30so2702392pvc.0 for ; Tue, 10 Aug 2010 08:25:04 -0700 (PDT) In-Reply-To: <733883921.20100810141351@gmail.com> (Ivanov Dmitry's message of "Tue, 10 Aug 2010 14:13:51 +0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ivanov Dmitry Cc: emacs-orgmode@gnu.org Hi, This patch has been applied with some very minor indentation and whitespace changes. Thanks for the patch and the elucidation of the comments and code. Best -- Eric Ivanov Dmitry writes: > * org-read-prop > ** added a more detailed comment > ** changed 2 if stements to 1 cond to make the code more comprehensible. > ** added > (condition-case nil > (read prop) > (error prop))) > > instead of > (read prop) > > so, if any error occurs during the conversion of prop to lisp expression - a string will be returned. > > ** The scheme of the new function if attached. > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode