From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, emacs-orgmode@gnu.org,
Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [Orgmode] Weird behaviour with org-yank and org-startup-indented
Date: Thu, 21 Oct 2010 13:40:34 -0400 [thread overview]
Message-ID: <87sjzzo359.fsf@stupidchicken.com> (raw)
In-Reply-To: <jwv4ocgepei.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 20 Oct 2010 13:38:16 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The problem is in org-indent-refresh-section, which is run from a timer.
>> This function first moves point and then calls remove-text-properties,
>> which is considered a buffer change. Since the mark is active, the
>> selection code saves the region to saved-region-selection, from which it
>> is later saved to the primary selection.
>
> Shouldn't org-indent-refresh-section use with-silent-modifications
> around the remove-text-properties call?
If we were starting from scratch, I think it's more sensible to make
text property changes "silent" by default, while providing an explicit
call to "unsilence" them when desired (which seem to be a minority of
cases). I guess it's too late to change now, though.
next prev parent reply other threads:[~2010-10-21 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 14:56 Weird behaviour with org-yank and org-startup-indented Julien Danjou
2010-10-17 6:08 ` Carsten Dominik
2010-10-18 14:37 ` Julien Danjou
2010-10-20 12:31 ` [Orgmode] " Julien Danjou
2010-10-20 15:09 ` Chong Yidong
2010-10-20 15:24 ` Julien Danjou
2010-10-20 15:38 ` Andreas Röhler
2010-10-20 15:58 ` [Orgmode] " Chong Yidong
2010-10-20 15:33 ` Chong Yidong
2010-10-20 15:37 ` Lennart Borgman
2010-10-20 17:38 ` Stefan Monnier
2010-10-21 17:40 ` Chong Yidong [this message]
2010-10-21 17:38 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjzzo359.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).