emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Lundin <mdl@imapmail.org>
To: "Sébastien Vauban"
	<public-wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@lo.gmane.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: org-src-fontify-natively makes things very, very slow
Date: Tue, 29 Mar 2011 10:49:45 -0400	[thread overview]
Message-ID: <87sju6nfqu.fsf@fastmail.fm> (raw)
In-Reply-To: <80wrjsun8p.fsf@somewhere.org> ("Sébastien Vauban"'s message of "Mon, 21 Mar 2011 23:23:18 +0100")

Sébastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
writes:

>>> Maybe this is (partly?) due to the overlay I added:
>>>
>>> #+begin_src emacs-lisp
>>>                 (overlay-put (make-overlay beg1 block-end)
>>>                              'face 'org-block-background))
>>> #+end_src
>
> See http://patchwork.newartisans.com/patch/581/ for a full diff. You can see I
> only add *one* overlay: for the background face.
>
>> (well, commenting out the whole condition that includes this code) makes no
>> difference at all.
>
> I'm surprised. Good to hear, but as some were finger pointing the overlays,
> and as I added one for every block... But, OK, better like that!
>
> For the sake of completeness, know that I first tried to add the background
> fontification as a text property, but that made the other properties disappear
> (annihilating the native fontification in fact). No a solution, or I did not
> try the right way -- which is entirely possible, seen my poor knowledge on
> this subject (I have to admit I succeeded by trials and errors).

I believe there is a bug here. I'm not sure if it is related to the
performance issues, but when org-src-fontify-natively is t, new overlays
keep getting added to the source block with each keypress in the source
block.

For instance, just typing this line of perl...

#+begin_src perl
  my @apples = ("golden delicious", "braeburn");
#+end_src

...resulted in 54 identical overlays being added to the buffer.

,----[ M-x describe-text-properties
| There are 54 overlays here:
|  From 39 to 88
|   face                 org-block-background
|  From 39 to 88
|   face                 org-block-background
|  From 39 to 88
|   face                 org-block-background
|  From 39 to 88
|   face                 org-block-background
| ....[and so on]
`----

The number keeps growing with more typing, since make-overlay is called
without a test to see if an overlay already exists. 

Best,
Matt 

  parent reply	other threads:[~2011-03-29 14:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 13:59 org-src-fontify-natively makes things very, very slow Julian Burgos
2011-03-17 18:28 ` Eric S Fraga
2011-03-17 20:34   ` Sébastien Vauban
2011-03-18  0:11     ` Julian Burgos
2011-03-18  8:38     ` Eric S Fraga
2011-03-18 12:44       ` Julian Burgos
2011-03-19  9:20       ` Sébastien Vauban
2011-03-19 12:28         ` suvayu ali
2011-03-19 20:37           ` Eric S Fraga
2011-03-19 20:34         ` Eric S Fraga
2011-03-20  4:23           ` Le Wang
2011-03-20 19:41             ` Eric S Fraga
2011-03-21  2:37               ` Le Wang
2011-03-21 13:57                 ` Eric Schulte
2011-03-21 17:06                   ` Eric S Fraga
2011-03-21 22:23                     ` Sébastien Vauban
2011-03-22  9:18                       ` Ulf Stegemann
2011-03-29 14:49                       ` Matt Lundin [this message]
2011-03-29 16:49                         ` Eric S Fraga
2011-03-30  7:34                         ` Sébastien Vauban
2011-04-28 20:59                     ` Carsten Dominik
2011-04-28 23:32                       ` Eric S Fraga
2011-04-30 19:45                         ` Eric S Fraga
2011-05-01 13:37                           ` Carsten Dominik
2011-03-29 14:12           ` Matt Lundin
2011-03-29 16:44             ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sju6nfqu.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=public-wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@lo.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).