From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [Bug] Regression w/ insert into tables in overwrite-mode Date: Tue, 27 Mar 2012 23:53:19 +0200 Message-ID: <87sjgtogmo.fsf@gnu.org> References: <87d392u4b4.fsf@Rainer.invalid> <87ehtghyb1.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:46954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCg5w-0004u1-2c for emacs-orgmode@gnu.org; Tue, 27 Mar 2012 19:46:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCg5u-0007jA-6Q for emacs-orgmode@gnu.org; Tue, 27 Mar 2012 19:46:31 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:42375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCg5t-0007im-TE for emacs-orgmode@gnu.org; Tue, 27 Mar 2012 19:46:30 -0400 Received: by werj55 with SMTP id j55so358192wer.0 for ; Tue, 27 Mar 2012 16:46:27 -0700 (PDT) In-Reply-To: <87ehtghyb1.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 27 Feb 2012 20:27:14 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > Achim Gratz writes: > >> Commit 00040e7 by David Maus has introduced a regression when inserting >> into org tables while overwrite mode is on. For each character inserted >> into a table cell, the cell (and the whole table row) gets shortened by >> one character. >> >> If the change can not be reverted, the deletion must not >> happen when overwrite mode is on, maybe through something like this: >> >> (if (not overwrite-mode) (delete-char -1)) > > The change cannot be reverted, since Emacs24 issues a compile-time > warning about using delete-backward-char, even though that warning has > been dropped from the doc string... so it needs to be protected or > replaced by an org-specific version that honors overwrite mode. I reverted David's change and replaced `delete-backward-char' by `backward-delete-char', which isn't caught by the compiler*. `backward-delete-char' is remapped to `delete-backward-char' by Emacs and `delete-backward-char' is remapped by Org to `org-delete-backward-char'. Thanks for your patience on this one! * This looks weird that an alias isn't caught by the compiler, I'll let Emacs devs know about this. -- Bastien