* [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing
@ 2012-07-28 3:43 Kyle Machulis
2012-07-28 5:57 ` Achim Gratz
0 siblings, 1 reply; 3+ messages in thread
From: Kyle Machulis @ 2012-07-28 3:43 UTC (permalink / raw)
To: emacs-orgmode
In commit abbea596111611a945d73783b3e8790e76599740, the commit message
starts with
- Move org-element.el from contrib/lisp to lisp/.
However, it looks like org-element.el just got deleted, not moved.
This causes much badness when trying to rebuild.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing
2012-07-28 3:43 [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing Kyle Machulis
@ 2012-07-28 5:57 ` Achim Gratz
2012-07-28 6:41 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Achim Gratz @ 2012-07-28 5:57 UTC (permalink / raw)
To: emacs-orgmode
Kyle Machulis writes:
> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
> starts with
>
> - Move org-element.el from contrib/lisp to lisp/.
>
> However, it looks like org-element.el just got deleted, not moved.
> This causes much badness when trying to rebuild.
Thanks for reporting, it seems Bastien missed a 'git add
lisp/org-element.el' before doing this commit (and broke a few other
things with additional changes in the same commit). I don't know if the
changes in org.el were intended to go live since there is no changelog
entry for those. If not, they will have to be reverted/changed
seperately but for now things compile and test cleanly again.
Fixed in 6347bf2f72.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing
2012-07-28 5:57 ` Achim Gratz
@ 2012-07-28 6:41 ` Bastien
0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2012-07-28 6:41 UTC (permalink / raw)
To: Achim Gratz; +Cc: emacs-orgmode
Achim Gratz <Stromeko@nexgo.de> writes:
> Kyle Machulis writes:
>> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
>> starts with
>>
>> - Move org-element.el from contrib/lisp to lisp/.
>>
>> However, it looks like org-element.el just got deleted, not moved.
>> This causes much badness when trying to rebuild.
>
> Thanks for reporting, it seems Bastien missed a 'git add
> lisp/org-element.el' before doing this commit
Indeed. Thanks for fixing this!
> (and broke a few other
> things with additional changes in the same commit). I don't know if the
> changes in org.el were intended to go live since there is no changelog
> entry for those.
There is a general ChangeLog:
Also move chunks of declarations and require statements to
get rid of compiler warnings.
> If not, they will have to be reverted/changed
> seperately but for now things compile and test cleanly again.
I opened a can of wo^W^Wcompiler warnings while moving org-element.el
to core: the way org.el requires libraries or those libraries require
'org is confusing, and there is still room for simplification. Let's
do this incrementally.
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-28 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-28 3:43 [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing Kyle Machulis
2012-07-28 5:57 ` Achim Gratz
2012-07-28 6:41 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).