From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Babel support for scheme using geiser Date: Sun, 06 Jan 2013 07:56:00 +0100 Message-ID: <87sj6ex0jj.fsf@bzg.ath.cx> References: <50E72B13.70709@no8wireless.co.nz> <87a9snlmhf.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Trk9O-00081j-KB for emacs-orgmode@gnu.org; Sun, 06 Jan 2013 01:56:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Trk9M-0005j3-64 for emacs-orgmode@gnu.org; Sun, 06 Jan 2013 01:56:06 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:64548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Trk9L-0005ix-Vk for emacs-orgmode@gnu.org; Sun, 06 Jan 2013 01:56:04 -0500 Received: by mail-we0-f181.google.com with SMTP id t11so8843550wey.40 for ; Sat, 05 Jan 2013 22:56:03 -0800 (PST) In-Reply-To: (Michael Gauland's message of "Sat, 5 Jan 2013 18:57:51 +0000 (UTC)") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Gauland Cc: emacs-orgmode@gnu.org Hi Michael, Michael Gauland writes: > Bastien altern.org> writes: >> In the meantime, please consider adding a >> commit ChangeLog for your patch, > > Most of the file has changed dramatically--would you like the changelog to list > all the functions that have been added or altered, or would a simple statement > that the file underwent a major re-write be more appropriate? Well, I'm afraid we'll have to go the clean way: just document the deleted functions, the new ones, and the ones that have been rewritten. No need to go too much into details. Also let's rename `cleanse-org-babel-scheme-repl-map' to `org-babel-scheme-cleanse-repl-map'. >> ...avoid dangling parentheses, > > Noted. That's a bad habit I've picked up somewhere (probably too many years of C > programming.) > >> and don't overwrite the first line... we are in 2013 > > Also noted. Part of my brain refuses to acknowledge the new year until I'm back > at work. Regrettably, that won't be a problem after tomorrow. Hehe, happy new year :) -- Bastien