emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Michael Gauland <mikelygee@no8wireless.co.nz>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Babel support for scheme using geiser
Date: Sun, 06 Jan 2013 07:56:00 +0100	[thread overview]
Message-ID: <87sj6ex0jj.fsf@bzg.ath.cx> (raw)
In-Reply-To: <loom.20130105T194856-468@post.gmane.org> (Michael Gauland's message of "Sat, 5 Jan 2013 18:57:51 +0000 (UTC)")

Hi Michael,

Michael Gauland <mikelygee@no8wireless.co.nz> writes:

> Bastien <bzg <at> altern.org> writes:
>> In the meantime, please consider adding a 
>> commit ChangeLog for your patch, 
>
> Most of the file has changed dramatically--would you like the changelog to list
> all the functions that have been added or altered, or would a simple statement
> that the file underwent a major re-write be more appropriate?

Well, I'm afraid we'll have to go the clean way: just document
the deleted functions, the new ones, and the ones that have been
rewritten.  No need to go too much into details.  

Also let's rename `cleanse-org-babel-scheme-repl-map' to
`org-babel-scheme-cleanse-repl-map'.

>> ...avoid dangling parentheses,
>
> Noted. That's a bad habit I've picked up somewhere (probably too many years of C
> programming.)
>
>> and don't overwrite the first line... we are in 2013 
>
> Also noted. Part of my brain refuses to acknowledge the new year until I'm back
> at work. Regrettably, that won't be a problem after tomorrow.

Hehe, happy new year :)  

-- 
 Bastien

next prev parent reply	other threads:[~2013-01-06  6:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 19:18 [PATCH] Babel support for scheme using geiser Michael Gauland
2013-01-05 14:42 ` Bastien
2013-01-05 18:57   ` Michael Gauland
2013-01-06  6:56     ` Bastien [this message]
2013-01-08 23:46       ` [PATCH] Use geiser for babel scheme evaluation Michael Gauland
2013-01-09  8:23         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj6ex0jj.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mikelygee@no8wireless.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).