From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: C-c ^ not fully useful
Date: Mon, 25 Feb 2013 11:22:42 +0100
Message-ID: <87sj4kn159.fsf@bzg.ath.cx>
References: <86vc9p1kiu.fsf@iro.umontreal.ca> <87hal0pws8.fsf@bzg.ath.cx>
	<DEA6D719-0CD3-476F-AAB5-E181C34D8F4A@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:59039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9vCt-0007ZH-Fk
	for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:22:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9vCo-0005IW-Ad
	for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:22:51 -0500
Received: from mail-wi0-f172.google.com ([209.85.212.172]:65247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U9vCo-0005I6-3A
	for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:22:46 -0500
Received: by mail-wi0-f172.google.com with SMTP id ez12so3161381wid.11
	for <emacs-orgmode@gnu.org>; Mon, 25 Feb 2013 02:22:45 -0800 (PST)
In-Reply-To: <DEA6D719-0CD3-476F-AAB5-E181C34D8F4A@gmail.com> (Carsten
	Dominik's message of "Mon, 25 Feb 2013 10:35:47 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: =?iso-8859-1?Q?Fran=E7ois?= Pinard <pinard@iro.umontreal.ca>, emacs-orgmode@gnu.org

Hi Carsten,

Carsten Dominik <carsten.dominik@gmail.com> writes:

> are you sure it removes emphasis markers as well?  Looks to me that
> org-sort-remove-invisible only removes links.  I guess it could be
> rewritten looking at invisibility properties, but that might be problematic
> when sorting includes a part of the buffer that has not yet been visible in
> a window and therefore might not be propertized properly.

You are right, the version that removes emphasis markers based on the
visibility[1] specs is buggy.  I tweaked `org-sort-remove-invisible'
so that it removes emphasis markers for good[2].  I did some testing
and it works okay, let me know if you anticipate any other problem.

Thanks,

[1] http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=30d6dc
[2] http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=662cb9

-- 
 Bastien