emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC] [patch] open/delete attachment with inherited directory
Date: Tue, 17 Dec 2013 18:34:54 +0100	[thread overview]
Message-ID: <87sitr8jpd.fsf@gmail.com> (raw)
In-Reply-To: <874n69fkxc.fsf@gmail.com> (Aaron Ecay's message of "Mon, 16 Dec 2013 00:02:07 -0500")

Hello,

Aaron Ecay <aaronecay@gmail.com> writes:

> I have some org files where each headline corresponds to an entry in a
> bibliography.  The headlines each have attached to them a pdf file of
> the corresponding document.  The attachment directory is set as a
> file-level property and inherited by the children (this is so that I can
> access the files easily also outside of org).
>
> In the current implementation of org-attach-{open,delete-one}, I am
> prompted to choose among all files in the attachment directory (i.e. all
> the pdfs of entries in the bibliography), not just the (usually single)
> file attached to the headline at point.  I think the latter behavior
> makes more sense.  The attached (heh) patch implements this change.  Are
> there any comments?

Thanks for the patch.

I see one major problem, though. Org attach doesn't require to list
files attached to the entry (see `org-attach-file-list-property').
Therefore, `org-entry-get-multivalued-property' could return nil even
though there are attached files.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2013-12-17 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  5:02 [RFC] [patch] open/delete attachment with inherited directory Aaron Ecay
2013-12-17 17:34 ` Nicolas Goaziou [this message]
2013-12-18  5:11   ` Aaron Ecay
2013-12-18 13:57     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sitr8jpd.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).