emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Patches for agenda exiting commands
Date: Sat, 03 Jan 2015 12:25:59 +0100	[thread overview]
Message-ID: <87sifs6r7c.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87iogog4xu.fsf@kmlap.domain.org> (Kyle Meyer's message of "Fri, 02 Jan 2015 18:04:29 -0500")

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> I've attached a few patches related to the agenda exiting commands.

Thank you. I applied patches 1, 2 and 3.

> Subject: [PATCH 4/5] org-agenda: Track last indirect buffer
>
> * lisp/org-agenda.el (org-agenda-tree-to-indirect-buffer): Record last
>   indirect buffer for agenda.
> * lisp/org-agenda.el (org-agenda-quit): Delete window for
>   org-agenda-last-indirect-buffer, not org-last-indirect-buffer.
>
> If an indirect buffer for an Org subtree was present as a window,
> org-agenda-quit deleted this window regardless of whether it was created
> from the agenda.  Introduce a new variable,
> org-agenda-last-indirect-buffer, that is specific for the agenda (and
> perhaps a particular agenda buffer, if org-agenda-sticky is set).
>
> org-agenda-quit checked for indirect buffers while org-agenda-Quit did
> not.  There doesn't seem to be any reason for this difference in
> behavior, so make org-agenda-Quit treat windows for indirect buffers the
> same way as org-agenda-quit.

Nitpick: in commit messages, prefer the present tense.

> +(defvar org-agenda-last-indirect-buffer nil)

Please provide a docstring for this new variable.

> Subject: [PATCH 5/5] org-agenda: Fix issues with restoring windows
>
> * lisp/org-agenda.el (org-agenda-prepare-window): Update window
>   configuration even when agenda buffer exists in background.
> * lisp/org-agenda.el (org-agenda-Quit): Use buffer value for
>   org-agenda-pre-window-conf to allow for local values used with sticky
>   agenda buffers.
> * lisp/org-agenda.el (org-agenda-quit): Reset local, not global, value for
>   org-agenda-pre-window-conf.
>
> The pre-agenda window configuration was not being updated, resulting in
> a window configuration other than the one prior to the most recent
> agenda call being restored, in the following cases:
>
> - The user exited or buried the buffer without using q, Q, or x.
> - org-agenda-sticky was non-nil and the user buried the buffer with q.
>   This was because the global, not buffer-local, value for
>   org-agenda-pre-window-conf was not being reset.
>
> Also, when org-agenda-sticky was non-nil, pressing Q (org-agenda-Quit)
> restored the global, not the buffer-local, value for
> org-agenda-pre-window-conf.
>
> Along with these changes, merge the duplicated functionality in
> org-agenda-quit and org-agenda-Quit.

Present tense, please.

Also, the commit message lacks the creation of `org-agenda--quit'.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2015-01-03 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02 23:04 [PATCH] Patches for agenda exiting commands Kyle Meyer
2015-01-03 11:25 ` Nicolas Goaziou [this message]
2015-01-05  4:24   ` Kyle Meyer
2015-01-05 11:50     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sifs6r7c.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).