From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Add a custom list in org-mac-link.el
Date: Thu, 15 Jun 2017 21:03:42 +0200
Message-ID: <87shj1gjjl.fsf@nicolasgoaziou.fr>
References: <CAJsv8TF0pfBBrj0nnL0GgsuqNoW2e60XsC9xxSvk79ukKMtLMw@mail.gmail.com>
	<87h8ziikze.fsf@nicolasgoaziou.fr>
	<CAJsv8THHp1gZ3rVEuXUbtOUO2S2LMqSemUP_A0o+5uCMrPA57A@mail.gmail.com>
	<87wp8dgqjv.fsf@nicolasgoaziou.fr>
	<CAJsv8TGOomBV4KoDg_+zhmHtv37QNANCdxYcWe-DCfv4FxTbdg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dLa3a-0001N7-MF
	for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 15:03:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dLa3X-0005I5-I6
	for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 15:03:50 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52976)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dLa3X-0005Hd-BU
	for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 15:03:47 -0400
In-Reply-To: <CAJsv8TGOomBV4KoDg_+zhmHtv37QNANCdxYcWe-DCfv4FxTbdg@mail.gmail.com>
	(Takaaki Ishikawa's message of "Fri, 16 Jun 2017 03:38:55 +0900")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Takaaki Ishikawa <takaxp@ieee.org>
Cc: orgmode list <emacs-orgmode@gnu.org>

Takaaki Ishikawa <takaxp@ieee.org> writes:

> Thank you for your kind feedback. Please find my comments below.

Thank you for the quick answer.

> Updated docstring is
>
>   "Alist of descriptors. Each descriptor consists of four elements to build
> the link grabber menu in the minibuffer. A single character shall be used
> for the first element to select an application, and the pair with the second
> element represents the name of the application. The third element is a
> function to insert information grabbed from selected application. And the
> last
> element is a flag to indicate whether the descriptor appears in the link
> grabber menu."

Nice. Note that we can make it more explicit, e.g.,

  A descriptor follows the pattern:

    (KEY NAME FUN FLAG)

  where KEY is ...

The first line needs to end with the first sentence, i.e.,
"descriptors". Also, you need two spaces after each sentence.

>> +  :tag "A list of descriptors"
>> > +  :group 'org-mac-link'
>> > +  :type 'symbol)
>>
>> The :type value is wrong. You need a composite type here.
>>
>
> What do you feel about the following composite type.
>
> :type '(alist :value-type (string string function boolean)

OK. You could introduce :tag to make it easier,e.g.

  (string :tag "Key: ")


Regards,