From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Add support for Babel with Eshell, (updated PATCH) Date: Mon, 23 Apr 2018 23:35:22 +0200 Message-ID: <87sh7lobc5.fsf@nicolasgoaziou.fr> References: <87d0ysroer.fsf@gmail.com> <87bmecrod4.fsf@gmail.com> <87a7twrmyv.fsf@gmail.com> <87po2q5kqk.fsf@nicolasgoaziou.fr> <87h8o26orj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAj7R-0006g0-W2 for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 17:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAj7O-0007jD-Rz for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 17:35:30 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60309) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAj7O-0007ex-KA for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 17:35:26 -0400 In-Reply-To: <87h8o26orj.fsf@gmail.com> (stardiviner's message of "Mon, 23 Apr 2018 21:22:40 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: org-mode stardiviner writes: > Hi, Nicolas, thank you always review my Org-mode patches. Yesterday, I > ask Bastein about Worg ox-org question. He mentioned I should at least > say "Hi" in message. I'm not good at English culture of something else. > But I just want to say, I'm glad you reviewed my patches. Really. Thanks > and that means a lot to me. You're welcome. > Aha, I found it, is there a way to auto sort this table automatically? > (Maybe format it into two columns instead of four columns even though it > looks short and better.) Adding one language into this table, then move > following languages in table one by one is awful. True. I usually define a quick Emacs macro when I need to shift a substantial part of this table. I'm not sure it is faster in the end, but it sure is more interesting. >> (mapc #'eshell-command var-lines) > > I previously patches, you mentioned to use `dolist`, so I used it this > time, what's the difference between mapc and dolist? I thought might be > performance or something else. Maybe looks cleaner? What I said it `mapc' + `lambda' => `dolist'. This is because calling lambda is somewhat inefficient in Emacs Lisp. So, instead of (mapc (lambda (e) (do stuff on e))), it is better to write (dolist (e ...) (do stuff on e)) since there is one level of indirection less. In the example above, there is no `lambda'. So (mapc #'function ...) is shorter and better. > I copy form other test-ob-*.el file template. forgot to change copyright > name. should I use my own name "stardiviner"? Sure. Regards,