From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: A few changes to test in master Date: Wed, 05 Feb 2020 07:21:54 +0100 Message-ID: <87sgjpd059.fsf@bzg.fr> References: <87wo9750jl.fsf@gnu.org> <87a75yrdye.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40771) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izE4T-000679-TS for emacs-orgmode@gnu.org; Wed, 05 Feb 2020 01:21:58 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: emacs-orgmode@gnu.org Hi Jack, Jack Kamm writes: > Bastien writes: > >> - M-x org-table-electric-header-mode RET will display the first row >> of the table at point in the header line when the first row is not >> visible anymore. > > This is great, it's a huge quality-of-life improvement for working with > long tables. Below are some issues I noticed when playing with it. Thanks for testing and taking the trouble to report these issues. > The variable `org-table-header-line-p' doesn't seem to have any effect > for me, I find that I need to call "M-x org-table-header-line-mode" even > when it's set. Should be fixed now. > Also, "M-x org-table-header-line-mode" seems to activate the minor mode > globally, despite a message suggesting it is only activated in the > current buffer. Maybe because we use "defvar" instead of "defvar-local" > to define its variable? > > I tried replacing the "defvar" with "defvar-local", it seemed to fix the > global activation of the minor mode, but still it seems the hooks added > are still active in other org buffers. So if I activate the mode in > buffer A, then view a long table in buffer B, I see the table header > when scrolling through it, even though the mode isn't active in B. Well, I tried various things and I didn't fix this one. Perhaps this is due to the special display of the header line. I will continue to look for a solution. > If I am in a table, and scroll-up-command brings me out of the table, > then the header of the table still sits on top of the window immediately > after scrolling. This gets fixed as soon as any action is taken > (e.g. moving the cursor or hitting C-g). Yes, this happened to me sometimes. I think I enhanced the situation a bit here, but I can't tell for 100% sure. Please test and report. > It would be nice if the header row was a little more visually > distinguishable from the other table rows (maybe by adding an underline > to that row?) Good idea, done - you can now customize the face: M-x customize-face RET org-table-header RET > Feature request (for Org 9.5?): > > It would be great if an analogous feature could be added for the > left-most column of a table, so if a table is very wide, and I scroll to > the right, I could still see which row index I'm in. Yes. I am still trying to precisely see the problem and solve it in a way that's not too invasive. Best, -- Bastien