From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GJ0vDI+KDF9tLAAA0tVLHw (envelope-from ) for ; Mon, 13 Jul 2020 16:23:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kFjnB4+KDF/ITAAAbx9fmQ (envelope-from ) for ; Mon, 13 Jul 2020 16:23:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C934A940215 for ; Mon, 13 Jul 2020 16:23:42 +0000 (UTC) Received: from localhost ([::1]:55772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jv1Ez-0007jY-QZ for larch@yhetil.org; Mon, 13 Jul 2020 12:23:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jv1EX-0007jL-Ie for emacs-orgmode@gnu.org; Mon, 13 Jul 2020 12:23:13 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:58119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jv1EV-000365-44 for emacs-orgmode@gnu.org; Mon, 13 Jul 2020 12:23:13 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id F3014100003; Mon, 13 Jul 2020 16:23:07 +0000 (UTC) From: Nicolas Goaziou To: "James N. V. Cash" Subject: Re: [PATCH] Make org-eldoc work with Emacs 28 References: <878sfrnxvp.fsf@gmail.com> Mail-Followup-To: "James N. V. Cash" , emacs-orgmode@gnu.org Date: Mon, 13 Jul 2020 18:23:06 +0200 In-Reply-To: <878sfrnxvp.fsf@gmail.com> (James N. V. Cash's message of "Fri, 10 Jul 2020 12:22:18 -0400") Message-ID: <87sgdv1j11.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=mail@nicolasgoaziou.fr; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 12:23:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: u9cBwCVh/IAU Hello, "James N. V. Cash" writes: > In Emacs 28, eldoc now passes in a callback to the documentation > functions. This breaks org-eldoc as it currently is, as > org-eldoc-documentation-function gets called with the wrong number of > arguments. > > This patch makes it continue to work by setting the new variable > eldoc-documentation-strategy, which puts eldoc in > "backwards-compatability" mode. Thank you. Do we need another variable for that? Could org-eldoc-documentation-funicton catch wrong-number-of-arguments error, and try another call instead? Regards, -- Nicolas Goaziou