From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "James N. V. Cash" <james.nvc@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make org-eldoc work with Emacs 28
Date: Mon, 13 Jul 2020 18:23:06 +0200 [thread overview]
Message-ID: <87sgdv1j11.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878sfrnxvp.fsf@gmail.com> (James N. V. Cash's message of "Fri, 10 Jul 2020 12:22:18 -0400")
Hello,
"James N. V. Cash" <james.nvc@gmail.com> writes:
> In Emacs 28, eldoc now passes in a callback to the documentation
> functions. This breaks org-eldoc as it currently is, as
> org-eldoc-documentation-function gets called with the wrong number of
> arguments.
>
> This patch makes it continue to work by setting the new variable
> eldoc-documentation-strategy, which puts eldoc in
> "backwards-compatability" mode.
Thank you.
Do we need another variable for that? Could
org-eldoc-documentation-funicton catch wrong-number-of-arguments error,
and try another call instead?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-07-13 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:22 [PATCH] Make org-eldoc work with Emacs 28 James N. V. Cash
2020-07-13 16:23 ` Nicolas Goaziou [this message]
[not found] ` <87zh83l66q.fsf@gmail.com>
2020-07-13 16:41 ` James N. V. Cash
2020-07-16 1:20 ` Basil L. Contovounesios
2020-07-16 4:29 ` Kyle Meyer
2020-07-16 14:34 ` James N. V. Cash
2020-07-17 5:41 ` [PATCH] org-eldoc: Fix compatibility " Kyle Meyer
2020-07-17 10:12 ` Basil L. Contovounesios
2020-07-17 16:13 ` Eric Abrahamsen
2020-07-17 22:11 ` Kyle Meyer
2020-07-17 11:24 ` Joseph Mingrone
2020-07-19 0:20 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgdv1j11.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=james.nvc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).