From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YFfUAMuuWF+DZwAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 10:30:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +NY0OMquWF9zXwAAbx9fmQ (envelope-from ) for ; Wed, 09 Sep 2020 10:30:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6407894051F for ; Wed, 9 Sep 2020 10:30:34 +0000 (UTC) Received: from localhost ([::1]:33154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFxN2-0003Cr-BM for larch@yhetil.org; Wed, 09 Sep 2020 06:30:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFxMT-0003B7-6T for emacs-orgmode@gnu.org; Wed, 09 Sep 2020 06:29:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59221) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFxMS-0004rs-U9; Wed, 09 Sep 2020 06:29:56 -0400 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:37234 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kFxMS-0000a3-4n; Wed, 09 Sep 2020 06:29:56 -0400 Received: by guerry (Postfix, from userid 1000) id 06C231A60D3E; Wed, 9 Sep 2020 12:29:54 +0200 (CEST) From: Bastien To: No Wayman Subject: Re: [PATCH] org-add-planning-info: respect caller's given time [9.3.7 (release_9.3.7-716-g3d4876 @ /home/n/.emacs.d/straight/build/org/)] Organization: GNU References: <87zh6rfvmi.fsf@gmail.com> <87ft7wdxjl.fsf@gnu.org> <871rjgi4mb.fsf@gmail.com> <87mu239q8b.fsf@gnu.org> <87blihpndy.fsf@gmail.com> <875z8opt80.fsf@gnu.org> <877dt3wons.fsf@gmail.com> Date: Wed, 09 Sep 2020 12:29:53 +0200 In-Reply-To: <877dt3wons.fsf@gmail.com> (No Wayman's message of "Wed, 09 Sep 2020 00:37:59 -0400") Message-ID: <87sgbrw8da.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: wVr9TC+8+f3E No Wayman writes: > Bastien writes: > >> Hi No Wayman, >> >> I pushed 4f49ebb6d, a small variant of your initial patch, >> which pass the test fine by checking whether the variables >> are bound outside or not, ignoring them if not. >> >> Thanks again for the fix! > > Sounds good to me! Thanks, Bastien. Well, back to square one -- the "fix" breaks setting the end time of an existing schedule timestamp for me with. I reverted it as 771c66f79. -- Bastien