From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eIXRDQvDaV+mdwAA0tVLHw (envelope-from ) for ; Tue, 22 Sep 2020 09:25:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qEueCQvDaV9lagAAbx9fmQ (envelope-from ) for ; Tue, 22 Sep 2020 09:25:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C827C940365 for ; Tue, 22 Sep 2020 09:25:30 +0000 (UTC) Received: from localhost ([::1]:47334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKeYD-0004Tm-Ni for larch@yhetil.org; Tue, 22 Sep 2020 05:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeGI-0003wc-Gq for emacs-orgmode@gnu.org; Tue, 22 Sep 2020 05:06:58 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:43468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKeGG-0003Oh-Ij for emacs-orgmode@gnu.org; Tue, 22 Sep 2020 05:06:58 -0400 Received: by mail-pg1-x52d.google.com with SMTP id t14so11415813pgl.10 for ; Tue, 22 Sep 2020 02:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=w9G0JSxOLIEKh4nOGd6k6UC9ieN2fI9uzjNssesCNIg=; b=Sn2x4DRucFoBpDanf0e5M6po9v2TVjmY2neWT+Eu+jGoRye4zzPZZBhxTkNWPM6W2x EQQitlZSZoNqioUHHRzfGz3heMNkYP5lxF/7SItQZEcceAcDuS7pPlvzR639ipS/q8fg urlWqKrr2A5LrH/fmyWNYSSnEeE5axtaiObgV+hWl6om6QuWXjdnkgiqboAQb4lazX4S mE6Ss48e27de+xKCIRlU4yBfvTU2kV+5CfjkhxgHJwR6PtyjojfMMVqKB3bTcmEqfK26 8VRNZyjCJYPBXhYgEVPHhsO1tXn4dhOf2ANpsGNQHVy4rQckVPDaqMFkj6ca9Gv+jjKx kDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=w9G0JSxOLIEKh4nOGd6k6UC9ieN2fI9uzjNssesCNIg=; b=a21fargozgQ2muspK5qtKndjhWbpIvS4H60fgEh0skXjqyxuxtBeIbFYy00hkbq/HP 9eVqZ1S0YZAWQjheMN0pJu7kUDdHZe0QcoUnvCKKxU350eiJFRaw2gaAgYAw5na/B9tx l2baBLZrIARPKxSRRNMWXs/ZzmprSPr/BQ6t74ie7V6IvfQRvsXiqJE04HHNMoSi5Uwb j7E5c4qqptEmDLauPReROWs8tky7lTS0ciEzAjvxah58RkNYb6ATOu7ctmLffk/Gt25V Y2oEe85vVu8v6Eup+8jN5W8gIgPawGukhw6ZzvfPPY9+2HnqUhvQshV8/dCaRP61pYUD nQkw== X-Gm-Message-State: AOAM530Mc4S9WI/JP7nXmjDCvtQtC/ojGF1CsYyqA/+wBKV5O579pprU BtjklJVbCgsDrMe3LNDg+H8= X-Google-Smtp-Source: ABdhPJwoUsOtUf/EHpRJtbchBblVXa53cJqdLnI3GsWb10jrjIDrBcuohrwUD/r3LScI7iwGUsEEBw== X-Received: by 2002:a17:902:b08a:b029:d1:e5e7:be1c with SMTP id p10-20020a170902b08ab02900d1e5e7be1cmr3881586plr.79.1600765614439; Tue, 22 Sep 2020 02:06:54 -0700 (PDT) Received: from localhost ([210.3.160.218]) by smtp.gmail.com with ESMTPSA id f6sm13711215pfq.82.2020.09.22.02.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 02:06:52 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , emacs-orgmode@gnu.org Subject: Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers In-Reply-To: <87sgbc4qpl.fsf@gmail.com> References: <87h7x9e5jo.fsf@localhost> <87imh34usq.fsf@localhost> <87pnbby49m.fsf@nicolasgoaziou.fr> <87tv0efvyd.fsf@localhost> <874kse1seu.fsf@localhost> <87r1vhqpja.fsf@nicolasgoaziou.fr> <87tv0d2nk7.fsf@localhost> <87o8qkhy3g.fsf@nicolasgoaziou.fr> <87sgfqu5av.fsf@localhost> <87sgfn6qpc.fsf@nicolasgoaziou.fr> <87367d4ydc.fsf@localhost> <87r1uuotw8.fsf@nicolasgoaziou.fr> <87mu5iq618.fsf@localhost> <87ftb9pqop.fsf@nicolasgoaziou.fr> <875zc2du63.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com> Date: Tue, 22 Sep 2020 17:05:49 +0800 Message-ID: <87sgbaw58y.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Sn2x4DRu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: i2EO10ICxUwT > I get a conflict in org.el, on the hunk where org-reveal-location > and org-show-context-detail are defined; since your patch just > deletes them, I resolve this with: That's because the patch was against 0afef17e1. The new version of the patch (same URL) is against aea1109ef now. > I've tried going to doc/, running=20 > > emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded nil= )' \ > --eval '(add-to-list '"'"'load-path "../lisp")' \ > --eval '(load "../mk/org-fixup.el")' > > then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't > get a stacktrace. I'm guessing this is because this error (which IIUC > originates from org-back-to-heading in org.el) is a user-error; however, > if I change the function to raise a "regular error", then everything > compiles fine=E2=80=A6 =F0=9F=98=95 I suspect that you forgot to run =3Dmake clean=3D (to remove old untracked .elc files). Best, Ihor K=C3=A9vin Le Gouguec writes: > Hi! > > Ihor Radchenko writes: > >> The current version of the patch (against master) is in >> https://gist.github.com/yantar92/6447754415457927293acda43a7fcaef > > I'm probably missing something obvious, but when applying your patch on > top of master[1], make fails when generating manuals: > >> emacs -Q -batch --eval '(setq vc-handled-backends nil org-startup-folde= d nil)' \ >> --eval '(add-to-list '"'"'load-path "../lisp")' \ >> --eval '(load "../mk/org-fixup.el")' \ >> --eval '(org-make-manuals)' >> Loading /home/peniblec/Downloads/sources/emacs-meta/org-mode/mk/org-fixu= p.el (source)... >> Before first headline at position 760959 in buffer org-manual.org<2> >> make[1]: *** [Makefile:31: org.texi] Error 255 > > I've tried going to doc/, running=20 > > emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded nil= )' \ > --eval '(add-to-list '"'"'load-path "../lisp")' \ > --eval '(load "../mk/org-fixup.el")' > > then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't > get a stacktrace. I'm guessing this is because this error (which IIUC > originates from org-back-to-heading in org.el) is a user-error; however, > if I change the function to raise a "regular error", then everything > compiles fine=E2=80=A6 =F0=9F=98=95 > > > [1] git apply --3way, on top of commit b64ba64fe. > > I get a conflict in org.el, on the hunk where org-reveal-location > and org-show-context-detail are defined; since your patch just > deletes them, I resolve this with: > > git checkout --theirs -- lisp/org.el