From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QBfiIBGa9l+1agAA0tVLHw (envelope-from ) for ; Thu, 07 Jan 2021 05:20:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ULmnHBGa9l/IUgAAB5/wlQ (envelope-from ) for ; Thu, 07 Jan 2021 05:20:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 207349404D0 for ; Thu, 7 Jan 2021 05:20:17 +0000 (UTC) Received: from localhost ([::1]:42826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxNiZ-0008Jw-PD for larch@yhetil.org; Thu, 07 Jan 2021 00:20:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxNhs-0008Ja-RQ for emacs-orgmode@gnu.org; Thu, 07 Jan 2021 00:19:32 -0500 Received: from out0.migadu.com ([94.23.1.103]:36702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxNhp-0006V2-Ly for emacs-orgmode@gnu.org; Thu, 07 Jan 2021 00:19:32 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1609996764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWlLQEKSFS9UTaPCHDYxhdRp4i05h5NJcS49HTV46Cc=; b=I9qs7geGgDCeB54rwJ8C7VFiirHCqn7ZahZkqCPyf01WkqFOjRl4sosr35zaMh3A3SOSVM mcbmnBbymMHYbCBquL6PAwsjkF8U66uLSXpXUCgQISpMGhjRXMsFZOEuQPeMXIEUrV14bc AE7aDvhzwfaQqKKCJqWXWsuZLiOg6aQ696LdbHmyP8a4ZicOShV9AZ+dc892cDcwNDRADT bGsreZtKkF80QyYlrqOONNGjf66fBRbwckeNj20LlInqSHepmRL8TUYXINwGf7bPuaKSpn egpJuavqw8TKHnDnJDqTTG0Hg/PZSLqEGtcKmPdapOcm9Z7cl/8r/NvbncxvLg== From: Kyle Meyer To: Marco Wahl Subject: Re: Request to backport from Emacs 28 In-Reply-To: <87o8i2cpb2.fsf@gmail.com> References: <87o8i2cpb2.fsf@gmail.com> Message-ID: <87sg7dxr1h.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Thu, 07 Jan 2021 05:19:24 GMT Received-SPF: pass client-ip=94.23.1.103; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=I9qs7geG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 207349404D0 X-Spam-Score: -2.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: BlWw4pTg0tGv Marco Wahl writes: > Hello, > > The Emacs guys changed the signature of define-obsolete-function-alias. > > Eli Zaretskii: > > The use of this (and a couple of other) functions without the WHEN > argument has been obsolete since Emacs 23.1. > > The packages should adapt. > > AFAICS there is only usage of the obsolete usage in Org in > org-refile.el. > > This is fixed already in Emacs 28. So I think that fix should be merged > into the Org maint and master branches. > > Kyle! Are you the one who'll do that? Yes. Porting from Emacs's master to our maint branch has been on hold leading up to the Emacs 27.2 release to avoid any syncs carrying those commits into the emacs-27 branch [1]. [1] A list of those commits is here: https://git.kyleam.com/orgmode-backport-notes/tree/orgmode-backports.org#n62 The fix you're referring to on Emacs's master branch 5ada3eecec (lisp/org/org-refile.el (org-copy): Fix missing obsoletion version, 2020-12-17) is in these held commits. However, I wasn't yet aware of the more recent commit associated with the message you quoted above: 32c6732d16 (lisp/emacs-lisp/byte-run.el (make-obsolete): Make `when` mandatory, 2021-01-03). That makes it important to apply 5ada3eecec to Org's maint for compatibility with Emacs's master branch. > In a further step I think the critical line should move to org-compat as > all the other similar lines. Indeed. Ported (248dfcd71) and moved (33de2bd8e). Thanks for the heads up.