emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Marco Wahl <marcowahlsoft@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Request to backport from Emacs 28
Date: Thu, 07 Jan 2021 05:19:24 GMT	[thread overview]
Message-ID: <87sg7dxr1h.fsf@kyleam.com> (raw)
In-Reply-To: <87o8i2cpb2.fsf@gmail.com>

Marco Wahl writes:

> Hello,
>
> The Emacs guys changed the signature of define-obsolete-function-alias.
>
> Eli Zaretskii:
>
>     The use of this (and a couple of other) functions without the WHEN
>     argument has been obsolete since Emacs 23.1.
>
>     The packages should adapt.
>
> AFAICS there is only usage of the obsolete usage in Org in
> org-refile.el.
>
> This is fixed already in Emacs 28. So I think that fix should be merged
> into the Org maint and master branches.
>
> Kyle! Are you the one who'll do that?

Yes.  Porting from Emacs's master to our maint branch has been on hold
leading up to the Emacs 27.2 release to avoid any syncs carrying those
commits into the emacs-27 branch [1].

  [1] A list of those commits is here:
      https://git.kyleam.com/orgmode-backport-notes/tree/orgmode-backports.org#n62

The fix you're referring to on Emacs's master branch 5ada3eecec
(lisp/org/org-refile.el (org-copy): Fix missing obsoletion version,
2020-12-17) is in these held commits.  However, I wasn't yet aware of
the more recent commit associated with the message you quoted above:
32c6732d16 (lisp/emacs-lisp/byte-run.el (make-obsolete): Make `when`
mandatory, 2021-01-03).  That makes it important to apply 5ada3eecec to
Org's maint for compatibility with Emacs's master branch.

> In a further step I think the critical line should move to org-compat as
> all the other similar lines.

Indeed.  Ported (248dfcd71) and moved (33de2bd8e).

Thanks for the heads up.


      reply	other threads:[~2021-01-07  5:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 10:50 Request to backport from Emacs 28 Marco Wahl
2021-01-07  5:19 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg7dxr1h.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=marcowahlsoft@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).