emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Anthony Carrico <acarrico@memebeam.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: JavaScript in HTML export not recognized by LibreJS as free [9.4.5 (9.4.5-16-g94be20-elpaplus @ /home/jorge/.config/emacs/elpa/org-plus-contrib-20210412/)]
Date: Sat, 01 May 2021 11:30:18 +0200	[thread overview]
Message-ID: <87sg36rec5.fsf@bzg.fr> (raw)
In-Reply-To: <498dbe2e-0cd2-c81e-7960-4a26c566a1f7@memebeam.org> (Anthony Carrico's message of "Mon, 26 Apr 2021 16:36:28 -0400")

Hi Anthony,

Anthony Carrico <acarrico@memebeam.org> writes:

> The original implementation flip-flops between cached and normal
> classes (six statements removed in the original patch), whereas my
> clone adds and removes a class name from the classList (three
> statements inserted in the original patch). 

Thanks - I replayed this change with commit dcd7b576b in maint.

> I did intend to make a
> material change which would create a new public domain implementation
> of the original API. I did not intended to disrespect Carsten's work
> or to detract from it, and I apologize to anyone who did not consider
> it to be a good-faith gesture. I did honestly believe that the
> org-mode code base would welcome a public domain clone of the script
> functionality to resolve the issue at hand.

Absolutely no need to apologize here!  Sorry if my message was read as
a reproach, it was definitely not.

> I did offer an opinion on license insertion: My opinion is that
> org-export is a means to save an org-mode file in html format, and
> that org-mode authors don't view their documents as derivative works
> of the org-export markup. I still believe inserting a license into
> exported documents is a mistake.

FWIW I also think inserting Javascript in HTML export is wrong.
Commit bb24248b8 turns `org-html-head-include-scripts' to nil by
default, I advertized the change in etc/ORG-NEWS.

> Bastien: You certainly have my permission to use my
> CodeHighlightOn/CodeHighlightOff implementation as you see fit,
> including licensing it under the GPLv3+

Done, thanks for explicitely permitting this.

In general, I tend to agree that we should get rid of this small
Javascript snippet and that the feature provided is not critical,
but let's keep it until someone shows that he can reactivate it
with some existing Javascript library.

Thanks,

-- 
 Bastien


  reply	other threads:[~2021-05-01  9:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 20:26 Jorge P. de Morais Neto
2021-04-20  3:09 ` Kyle Meyer
2021-04-20  4:55   ` Tim Cross
2021-04-22 20:42     ` Anthony Carrico
2021-04-22 21:20       ` Tim Cross
2021-04-22 22:35         ` Anthony Carrico
2021-04-22 20:29   ` Anthony Carrico
2021-04-23  1:42     ` Anthony Carrico
2021-04-26 12:43     ` Bastien
2021-04-26 20:36       ` Anthony Carrico
2021-05-01  9:30         ` Bastien [this message]
2021-04-26 12:45     ` Jorge P. de Morais Neto
2021-04-26 16:57       ` Bastien
2021-04-27 17:57         ` Jorge P. de Morais Neto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg36rec5.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=acarrico@memebeam.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Bug: JavaScript in HTML export not recognized by LibreJS as free [9.4.5 (9.4.5-16-g94be20-elpaplus @ /home/jorge/.config/emacs/elpa/org-plus-contrib-20210412/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).